Skip to content

[Cypress] Only save videos if there are failing tests #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
billhimmelsbach merged 1 commit into from
Apr 10, 2025
Merged

[Cypress] Only save videos if there are failing tests #2473

billhimmelsbach merged 1 commit into from
Apr 10, 2025

Conversation

@billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Apr 8, 2025 •
edited
Loading

Changes

  • delete videos that don't contain a test failure, as per the docs

Testing

  1. Does the test suite run normally?
  2. Do tests that pass not have saved videos?
    Screenshot 2025-04-07 at 6 05 00 PM
  3. Do tests that fail still have saved videos?
    Screenshot 2025-04-07 at 6 07 28 PM

Closes: #2472

@billhimmelsbach billhimmelsbach requested a review from ojbravo April 8, 2025 01:09
ojbravo
ojbravo approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@billhimmelsbach billhimmelsbach merged commit 1e2f194 into master Apr 10, 2025
1 of 2 checks passed
@billhimmelsbach billhimmelsbach deleted the 2472-only-save-failing-test-runs branch April 10, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ojbravo ojbravo ojbravo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Testing] Only save videos of failing test runs

3 participants

@billhimmelsbach @ojbravo