feat: Removed phantomjs dependency#1204
Merged
keithamus merged 3 commits intochaijs:masterfrom Nov 9, 2018
Merged
Conversation
BREAKING CHANGE: Added support for chrome headless Signed-off-by: ossdev07 <ossdev@puresoftware.com>
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 32 32
Lines 1676 1676
Branches 404 404
=======================================
Hits 1584 1584
Misses 92 92Continue to review full report at Codecov.
|
Contributor
Author
|
Ping @keithamus @meeber Can you please have a look at this PR. |
keithamus
approved these changes
Nov 9, 2018
Member
|
Agreed. Also not a breaking change - the code is still the same. |
Contributor
Author
|
Thanks, for approving this PR. |
Closed
This was referenced Mar 5, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Added support for chrome headless
Phantomjs is an unmaintained project, removed phantomjs dependency from package.json, karma.conf.js, and Makefile. Added chrome headless support in package.json, karma.conf.js, and Makefile.
package-lock.json file got updated whenever we run the package.
Signed-off-by: ossdev07 ossdev@puresoftware.com