Skip to content

fix: print logs from all childloggers with a tag if the test itself has none#6084

Merged
MxmUrw merged 1 commit intomainfrom
fix/print-outputs-of-all-child-loggers-in-bouncer
Sep 3, 2025
Merged

fix: print logs from all childloggers with a tag if the test itself has none#6084
MxmUrw merged 1 commit intomainfrom
fix/print-outputs-of-all-child-loggers-in-bouncer

Conversation

@MxmUrw
Copy link
Contributor

@MxmUrw MxmUrw commented Sep 2, 2025

Some tests have a list of subfunctions that test a given functionality with different inputs (e.g. the FillOrKill test checking that FoK paramers work for various assets). These tests create child loggers with a {tag: ...} binding. The previous implementation of test-local-logs did not collect the logs for tagged children when an error is thrown.

Changes:

  • When an error is thrown at the top level of a test, collect logs not only from the logfile of that test, but also try to get a list of all possibly tagged child log files.

@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/print-outputs-of-all-child-loggers-in-bouncer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MxmUrw MxmUrw marked this pull request as ready for review September 2, 2025 12:25
@MxmUrw MxmUrw requested review from dandanlen and removed request for martin-chainflip September 2, 2025 12:25
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dandanlen dandanlen added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@MxmUrw MxmUrw added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@MxmUrw MxmUrw added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@dandanlen dandanlen added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@MxmUrw MxmUrw added this pull request to the merge queue Sep 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2025
@MxmUrw MxmUrw added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 0f1c6bb Sep 3, 2025
53 of 54 checks passed
@MxmUrw MxmUrw deleted the fix/print-outputs-of-all-child-loggers-in-bouncer branch September 3, 2025 17:29
MxmUrw added a commit that referenced this pull request Sep 4, 2025
… has none (#6084)

fix: print logs from all childloggers with a `tag` if the test itself has no tag.
dandanlen pushed a commit that referenced this pull request Sep 5, 2025
… has none (#6084)

fix: print logs from all childloggers with a `tag` if the test itself has no tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants