Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… has none (#6084) fix: print logs from all childloggers with a `tag` if the test itself has no tag.
… has none (#6084) fix: print logs from all childloggers with a `tag` if the test itself has no tag.
Some tests have a list of subfunctions that test a given functionality with different inputs (e.g. the FillOrKill test checking that FoK paramers work for various assets). These tests create child loggers with a
{tag: ...}binding. The previous implementation of test-local-logs did not collect the logs for tagged children when an error is thrown.Changes: