fix: use dedicated wallet for BLS tests.#6091
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request is not mergeable
Pull Request
Closes: PRO-2512
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Previously, we used our default wallet for the BLS tests, which means that if the DM marks a tx which spends change back into the wallet as tainted, and that UTXO is used later on to constructs txs for other tests, the DM will reject these other transactions, inadvertently.
Fix: we now use a dedicated wallet, so taintedness should be confined to it.