feat: allow lp_subscribe_order_fills to return best blocks#6101
Merged
feat: allow lp_subscribe_order_fills to return best blocks#6101
lp_subscribe_order_fills to return best blocks#6101Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
239f47d to
878f33f
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dandanlen
approved these changes
Sep 9, 2025
dandanlen
reviewed
Sep 9, 2025
dandanlen
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-2444
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added optional parameter to the subscription to allow subscribing to best blocks instead of finalized only