Skip to content

feat: allow lp_subscribe_order_fills to return best blocks#6101

Merged
dandanlen merged 5 commits intomainfrom
feature/pro-2444
Sep 10, 2025
Merged

feat: allow lp_subscribe_order_fills to return best blocks#6101
dandanlen merged 5 commits intomainfrom
feature/pro-2444

Conversation

@marcellorigotti
Copy link
Contributor

Pull Request

Closes: PRO-2444

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Added optional parameter to the subscription to allow subscribing to best blocks instead of finalized only

@marcellorigotti marcellorigotti requested review from a team and nmammeri as code owners September 8, 2025 09:27
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/pro-2444

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marcellorigotti marcellorigotti requested review from dandanlen and removed request for a team and nmammeri September 8, 2025 09:28
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 0% 6 Missing ⚠️
state-chain/custom-rpc/src/lp.rs 0% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dandanlen dandanlen self-requested a review September 9, 2025 12:38
@dandanlen dandanlen self-requested a review September 9, 2025 14:04
@dandanlen dandanlen enabled auto-merge September 10, 2025 07:37
@dandanlen dandanlen added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit e029186 Sep 10, 2025
103 of 104 checks passed
@dandanlen dandanlen deleted the feature/pro-2444 branch September 10, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants