Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| pub enum FeeType<AccountId> { | ||
| NetworkFee(NetworkFeeTracker), | ||
| BrokerFee(Beneficiaries<AccountId>), | ||
| } |
There was a problem hiding this comment.
It looks like this shouldn't be necessary, so I'm curious why it was?
There was a problem hiding this comment.
Probably not necessary in the end, but I wanted to narrow down the issue so I defined everything explicitly without referring to type params indirectly via <T: Config>.
MxmUrw
left a comment
There was a problem hiding this comment.
Let's also add the --disable-mbm-checks flag to the try_runtime script, then the upgrade tests running in CI will be actually useful.
* fix: fix migrations for 1.11 * fix: clippy * fix: cargo audit RUSTSEC-2025-0057 * fix: --disable-mbm-checks
No description provided.