Skip to content

fix: fix migrations for 1.11#6103

Merged
dandanlen merged 4 commits intomainfrom
fix/1.11-migrations
Sep 8, 2025
Merged

fix: fix migrations for 1.11#6103
dandanlen merged 4 commits intomainfrom
fix/1.11-migrations

Conversation

@dandanlen
Copy link
Collaborator

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/1.11-migrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 8, 2025

Comment on lines +33 to +36
pub enum FeeType<AccountId> {
NetworkFee(NetworkFeeTracker),
BrokerFee(Beneficiaries<AccountId>),
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this shouldn't be necessary, so I'm curious why it was?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not necessary in the end, but I wanted to narrow down the issue so I defined everything explicitly without referring to type params indirectly via <T: Config>.

Copy link
Contributor

@MxmUrw MxmUrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add the --disable-mbm-checks flag to the try_runtime script, then the upgrade tests running in CI will be actually useful.

@dandanlen dandanlen enabled auto-merge September 8, 2025 19:36
@dandanlen dandanlen added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 97c3b49 Sep 8, 2025
53 checks passed
@dandanlen dandanlen deleted the fix/1.11-migrations branch September 8, 2025 21:09
MxmUrw pushed a commit that referenced this pull request Sep 9, 2025
* fix: fix migrations for 1.11

* fix: clippy

* fix: cargo audit RUSTSEC-2025-0057

* fix: --disable-mbm-checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants