fix(types): exclude DeepPartial<unknown[]> from ChartOptions interface#11867
Merged
etimberg merged 2 commits intochartjs:masterfrom Aug 16, 2024
Merged
Conversation
etimberg
reviewed
Aug 16, 2024
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
I think this change makes sense. Not sure why the CI is failing though since it seems unrelated
Contributor
Author
|
Thanks @etimberg! Oh, I can see that now - I haven't run ESLint locally and it seems like my formatting is not compliant with the rules - I'll fix that. |
LeeLenaleee
approved these changes
Aug 16, 2024
etimberg
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #11866 by excluding
DeepPartial<unknown[]>fromChartOptions.Closes #11866.