-
Notifications
You must be signed in to change notification settings - Fork 448
Added support for Windows Platform for oci metadata capturing. #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Butler <[email protected]>
tpowell-progress
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snohio cookstyle --chefstyle -a for the whitespace complaints below
Modernized Ruby syntax. Signed-off-by: Michael Butler <[email protected]>
|
My cookstyle seems to disagree with the one that is running in actions. All 4 of those files look good on my end. |
jaymzh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is fine, but you changed the style against the styleguide, please fix so we can review this without all the linter errors.
|
Modernized Ruby syntax to pass cookstyle --chefstyle. Signed-off-by: Michael Butler <[email protected]>
|
Recognized my issues. Looks good from a style perspective now. |
Modernized Ruby syntax to pass cookstyle --chefstyle. Signed-off-by: Michael Butler <[email protected]>
|
|
I need to hold on this one. I just received word from Oracle that the data we need is going to be in a new endpoint. I'll look at this tomorrow - 10/16/25. |
|
@snohio that can always be done as an additional PR. |
|
I'll create a new PR. |



Author: [email protected]
Added support for Windows platforms to collect OCI Metadata
Description
The update adds in support for the Windows platforms to collect OCI Metadata. Previously, the logic only validated a file that is placed on the linux filesystem. It now looks at the Winodws Registry with wmi_lite if that file is not in place.
This also adds a small fix for the reporting if anything other than a 200 comes back from the environment. We moved from a warn to a debug and also included the endpoint that failed for better error tracking. This is to help prevent incidents in the future.
Related Issue
#1890
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.