Skip to content

Conversation

@snohio
Copy link
Contributor

@snohio snohio commented Oct 3, 2025

Author: [email protected]

Added support for Windows platforms to collect OCI Metadata

Description

The update adds in support for the Windows platforms to collect OCI Metadata. Previously, the logic only validated a file that is placed on the linux filesystem. It now looks at the Winodws Registry with wmi_lite if that file is not in place.

This also adds a small fix for the reporting if anything other than a 200 comes back from the environment. We moved from a warn to a debug and also included the endpoint that failed for better error tracking. This is to help prevent incidents in the future.

Related Issue

#1890

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@snohio snohio requested review from a team and jaymzh as code owners October 3, 2025 18:42
Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snohio cookstyle --chefstyle -a for the whitespace complaints below

@snohio
Copy link
Contributor Author

snohio commented Oct 9, 2025

My cookstyle seems to disagree with the one that is running in actions. All 4 of those files look good on my end.

Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this is fine, but you changed the style against the styleguide, please fix so we can review this without all the linter errors.

@jaymzh
Copy link
Collaborator

jaymzh commented Oct 14, 2025

My cookstyle seems to disagree with the one that is running in actions. All 4 of those files look good on my end.

bundle exec rakestyle should get you the right thing

@jaymzh jaymzh added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Oct 14, 2025
@tpowell-progress tpowell-progress self-assigned this Oct 14, 2025
Modernized Ruby syntax to pass cookstyle --chefstyle.
Signed-off-by: Michael Butler <[email protected]>
@snohio
Copy link
Contributor Author

snohio commented Oct 14, 2025

Recognized my issues. Looks good from a style perspective now.

Modernized Ruby syntax to pass cookstyle --chefstyle.
Signed-off-by: Michael Butler <[email protected]>
@sonarqubecloud
Copy link

@snohio
Copy link
Contributor Author

snohio commented Oct 15, 2025

I need to hold on this one. I just received word from Oracle that the data we need is going to be in a new endpoint. I'll look at this tomorrow - 10/16/25.

@Stromweld
Copy link

@snohio that can always be done as an additional PR.

@snohio
Copy link
Contributor Author

snohio commented Oct 17, 2025

I'll create a new PR.

@jaymzh jaymzh closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants