flow-typed install to postinstall + add any exports for module(require)#917
Conversation
|
See https://flow.org/blog/2016/10/13/Flow-Typed/
|
|
@amilajack In this case you need to freeze packages versions, because if you will try to install all dependencies from scratch you willl see flow errors. |
|
Got it. So updating the flow types will fix this? I think a better solution would be to update the types in more frequent intervals. Thoughts on this? |
|
@amilajack Updating the flow will fix errors with redux lib, but stylelint and babel-plugin-flow-runtime still yield errors, so i added it to ignore list, also flow can't find module.js(And how!), i've added some kind of hack https://github.com/web-pal/electron-react-boilerplate/blob/master/flow-typed/npm/module_vx.x.x.js Anyway if you don't want new users will have flow errors we need to freeze dependencies versions, or at least mention in documentation about this issue(something like, if you see flow errors in node_modules, try to reinstall flow-typed). But i think if you don't have freezed dependencies, this advice makes no sense and we can use postinstall.
|
|
Thanks! |
As a new user i tried this boilerplate but found few flow issues.