Add coverlet code coverage

Author: chrisyarbrough

.github/workflows/test.yml

@@ -26,4 +26,10 @@ jobs:
       run: dotnet build src/UnityCommandLineLauncher.sln --no-restore
 
     - name: Test
-      run: dotnet test src/UnityCommandLineLauncher.sln --no-build
+      run: dotnet test src/UnityCommandLineLauncher.sln --no-build --collect:"XPlat Code Coverage"
+
+    - name: Upload coverage to Codecov
+      if: matrix.os == 'ubuntu-latest'
+      uses: codecov/codecov-action@v5
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }}

src/.gitignore

@@ -2,3 +2,5 @@
 
 bin/
 obj/
+
+ucll.tests/TestResults/

src/ucll.tests/OpenCommandTests.cs

@@ -1,14 +1,18 @@
-public class OpenCommandTests
+using Microsoft.Extensions.DependencyInjection;
+using Spectre.Console.Cli.Testing;
+using Xunit.Abstractions;
+
+public class OpenCommandTests(ITestOutputHelper output)
 {
 	[Fact]
 	public async Task WaitForFileAsyncFindsExistingFile()
 	{
-		await CreateTempProject(async tempDir =>
+		await TestUtil.WithinTempDirectoryAsync(async tempDir =>
 		{
-			string testFile = Path.Combine(tempDir, "test.sln");
+			string testFile = Path.Combine(tempDir.FullName, "test.sln");
 			await File.WriteAllTextAsync(testFile, "content");
 
-			string result = await OpenCommand.WaitForFileAsync(tempDir, "*.sln");
+			string result = await OpenCommand.WaitForFileAsync(tempDir.FullName, "*.sln");
 
 			Assert.Equal(testFile, result);
 		});
@@ -17,11 +21,11 @@ await CreateTempProject(async tempDir =>
 	[Fact]
 	public async Task WaitForFileAsyncWaitsForNewFile()
 	{
-		await CreateTempProject(async tempDir =>
+		await TestUtil.WithinTempDirectoryAsync(async tempDir =>
 		{
-			string testFile = Path.Combine(tempDir, "delayed.sln");
+			string testFile = Path.Combine(tempDir.FullName, "delayed.sln");
 
-			Task<string> waitTask = OpenCommand.WaitForFileAsync(tempDir, "*.sln");
+			Task<string> waitTask = OpenCommand.WaitForFileAsync(tempDir.FullName, "*.sln");
 
 			// Simulate Unity project generating the solution file.
 			await Task.Delay(100);
@@ -33,18 +37,24 @@ await CreateTempProject(async tempDir =>
 		});
 	}
 
-	private static async Task CreateTempProject(Func<string, Task> action)
+	[Fact]
+	public void Open_DirectPath()
 	{
-		string tempDir = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
-		Directory.CreateDirectory(tempDir);
+		var services = new ServiceCollection();
+		services.AddSingleton(PlatformSupport.Create());
+		services.AddSingleton<UnityHub>();
 
-		try
-		{
-			await action.Invoke(tempDir);
-		}
-		finally
+		var registrar = new TypeRegistrar(services);
+		var app = new CommandAppTester(registrar);
+		app.Configure(AppConfiguration.Build);
+
+		TestUtil.WithinTempDirectory(tempDir =>
 		{
-			Directory.Delete(tempDir, recursive: true);
-		}
+			string projectPath = Path.Combine(tempDir.FullName, "MyTestProject");
+			app.Run("create", projectPath, "6000.0.64f1", "--minimal");
+			var result = app.Run("open", projectPath, "--dry-run");
+			output.WriteLine(result.Output);
+			Assert.Equal(0, result.ExitCode);
+		});
 	}
 }

src/ucll.tests/TestUtil.cs

@@ -0,0 +1,32 @@
+internal static class TestUtil
+{
+	public static async Task WithinTempDirectoryAsync(Func<DirectoryInfo, Task> action)
+	{
+		string path = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+		DirectoryInfo directory = Directory.CreateDirectory(path);
+
+		try
+		{
+			await action.Invoke(directory);
+		}
+		finally
+		{
+			directory.Delete(recursive: true);
+		}
+	}
+
+	public static void WithinTempDirectory(Action<DirectoryInfo> action)
+	{
+		string path = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+		DirectoryInfo directory = Directory.CreateDirectory(path);
+
+		try
+		{
+			action.Invoke(directory);
+		}
+		finally
+		{
+			directory.Delete(recursive: true);
+		}
+	}
+}

src/ucll.tests/ucll.tests.csproj

@@ -6,6 +6,10 @@
 	</PropertyGroup>
 
 	<ItemGroup>
+		<PackageReference Include="coverlet.collector" Version="6.0.2">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
 		<PackageReference Include="Spectre.Console.Cli.Testing" Version="1.0.0-alpha.0.12" />
 		<PackageReference Include="xunit" Version="2.9.3" />

src/ucll/Shared/SearchPathCommand.cs

@@ -11,8 +11,7 @@ protected string ResolveSearchPath(string? searchPath, bool favoriteOnly)
 
 		if (!Directory.Exists(searchPath) && !File.Exists(searchPath))
 		{
-			WriteError($"'{searchPath}' does not exist.");
-			Environment.Exit(1);
+			throw new UserException($"'{searchPath}' does not exist.");
 		}
 		return searchPath;
 	}

src/ucll/ucll.csproj

@@ -38,7 +38,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<InternalsVisibleTo Include="ucll.Tests" />
+		<InternalsVisibleTo Include="ucll.tests" />
 	</ItemGroup>
 
 	<ItemGroup>