[ENH] Do not trace failed preconditions when flushing compaction. (#5155)

## Description of changes

The soft-deleted compaction will return an error that's not
distinguishable from other errors.  It will percolate to the dispatcher
and be logged like every other error.

In #5064, we added a should_trace_error function on the chroma Error
trait, which will silence the error at the dispatcher.  This PR applies
that annotation to the failed precondition.

## Test plan

CI

## Migration plan

N/A

## Observability plan

We get paged today.

We don't get paged in the future.

## Documentation Changes

N/A

Author: rescrv

rust/sysdb/src/sysdb.rs

@@ -1431,13 +1431,25 @@ pub enum FlushCompactionError {
 impl ChromaError for FlushCompactionError {
     fn code(&self) -> ErrorCodes {
         match self {
-            FlushCompactionError::FailedToFlushCompaction(_) => ErrorCodes::Internal,
+            FlushCompactionError::FailedToFlushCompaction(status) => {
+                if std::convert::Into::<chroma_error::ErrorCodes>::into(status.code())
+                    == ErrorCodes::FailedPrecondition
+                {
+                    ErrorCodes::FailedPrecondition
+                } else {
+                    ErrorCodes::Internal
+                }
+            }
             FlushCompactionError::SegmentFlushInfoConversionError(_) => ErrorCodes::Internal,
             FlushCompactionError::FlushCompactionResponseConversionError(_) => ErrorCodes::Internal,
             FlushCompactionError::CollectionNotFound => ErrorCodes::Internal,
             FlushCompactionError::SegmentNotFound => ErrorCodes::Internal,
         }
     }
+
+    fn should_trace_error(&self) -> bool {
+        self.code() == ErrorCodes::Internal
+    }
 }
 
 #[derive(Error, Debug)]