pre-pull external images

Author: codetheweb

.github/actions/tilt/action.yaml

@@ -14,6 +14,42 @@ runs:
       with:
         cpus: max
         memory: max
+    - name: Pre-pull images referenced in k8s manifests
+      shell: bash
+      run: |
+        set -euo pipefail
+
+        k8s_dir="k8s"
+
+        # Collect literal image references and ignore templated values
+        mapfile -t images < <(
+          grep -RhoE '^[[:space:]]*image:[[:space:]]*[[:graph:]]+' "$k8s_dir" |
+          grep -v '{{' |
+          sed -E 's/.*image:[[:space:]]*//' |
+          tr -d '"' |
+          grep -vi 'chroma-postgres' |                 # EXCLUDE chroma-postgres
+          sort -u
+        )
+
+        (( ${#images[@]} )) || { echo "No literal images found – nothing to pull."; exit 0; }
+
+        # Build a temporary docker-compose file
+        tmpfile=$(mktemp)
+        {
+          echo "version: '3.9'"
+          echo "services:"
+          for i in "${!images[@]}"; do
+            echo "  img$i:"
+            echo "    image: \"${images[$i]}\""
+          done
+        } > "$tmpfile"
+
+        echo "Generated compose file:"
+        cat "$tmpfile"
+
+        # Pull all images concurrently
+        docker compose -f "$tmpfile" pull --parallel --quiet
+
     - name: Start Tilt
       shell: bash
       run: tilt ci
@@ -30,9 +66,3 @@ runs:
         kubectl -n chroma port-forward svc/rust-frontend-service 3000:8000 &
         kubectl -n chroma port-forward svc/minio 9000:9000 &
         kubectl -n chroma port-forward svc/jaeger 16686:16686 &
-    - name: Export logs if it failed
-      if: failure()
-      shell: bash
-      run: |
-        kind export logs ./kind-logs
-        cat kind-logs

.github/workflows/pr.yml

@@ -164,8 +164,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup
-        uses: ./.github/actions/go
       - name: Set up Docker
         uses: ./.github/actions/docker
         with:
@@ -207,8 +205,8 @@ jobs:
 
   go-tests:
     name: Go tests
-    needs: change-detection
-    if: contains(fromJson(needs.change-detection.outputs.tests-to-run), 'go')
+    # needs: change-detection
+    # if: contains(fromJson(needs.change-detection.outputs.tests-to-run), 'go')
     uses: ./.github/workflows/_go-tests.yml
     secrets: inherit
 

k8s/distributed-chroma/values.yaml

@@ -135,3 +135,8 @@ garbageCollector:
         kube_namespace: "chroma"
         memberlist_name: "garbage-collection-service-memberlist"
         queue_size: 100
+
+loadService:
+  image:
+    repository: 'load-service'
+    tag: 'latest'

k8s/test/load-service.yaml

@@ -1,12 +1,10 @@
 ---
-
 apiVersion: v1
 kind: Namespace
 metadata:
   name: chroma-load
 
 ---
-
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -25,7 +23,7 @@ spec:
     spec:
       containers:
         - name: load-service
-          image: load-service
+          image: "{{ .Values.loadService.image.repository }}:{{ .Values.loadService.image.tag }}"
           imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 3001
@@ -50,7 +48,6 @@ spec:
             type: DirectoryOrCreate
 
 ---
-
 apiVersion: v1
 kind: ConfigMap
 metadata:
@@ -65,7 +62,6 @@ data:
       persistent_state_path: "/state/load-service.json"
 
 ---
-
 apiVersion: v1
 kind: Service
 metadata: