-
Notifications
You must be signed in to change notification settings - Fork 2k
[BLD]: use blacksmith pull-through container image cache for Tilt cluster #4542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
aef01d5 to
ca2b86e
Compare
462a939 to
72214eb
Compare
83e0639 to
a5e09e6
Compare
a5e09e6 to
e1c6021
Compare
|
Configure Blacksmith Pull-through Image Cache for Tilt CI Cluster This PR updates the GitHub Actions workflow for starting Tilt services in CI to address frequent Docker image pull failures caused by rate limiting or network issues. It replaces the direct kind cluster configuration with the use of the Blacksmith pull-through container image cache and switches to the helm/kind-action for cluster setup, ensuring more reliable image pulls. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
HammadB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update hosted/ as well. Although IIRC it may use this
…ster (chroma-core#4542) ## Description of changes We have been frequently seeing image pulls fail when starting Tilt in CI due to rate limiting/network issues. This configures the kind cluster to use blacksmith's provided pull-through image cache which should resolve these issues. ## Test plan _How are these changes tested?_ I changed the cache mirror port to be incorrect and observed that workflows immediately failed. ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_ n/a
Description of changes
We have been frequently seeing image pulls fail when starting Tilt in CI due to rate limiting/network issues. This configures the kind cluster to use blacksmith's provided pull-through image cache which should resolve these issues.
Test plan
How are these changes tested?
I changed the cache mirror port to be incorrect and observed that workflows immediately failed.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
n/a