Skip to content

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented May 28, 2025

Description of changes

Putting two logs on the same dirty log wasn't incorrect but wasn't going
to perform. This PR makes multiple log services possible now that the
frontend routes to them by collection ID.

This PR creates two rust-log-services and relies upon CI to uncover problems.

Test plan

CI

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Putting two logs on the same dirty log wasn't incorrect but wasn't going
to perform.  This PR makes multiple log services possible now that the
frontend routes to them by collection ID.

This PR creates two rust-log-services and relies upon CI to uncover problems.
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

Enable Unique Member ID Wiring for rust-log-service Dirty Logs

This PR updates the rust-log-service so that each instance uses a unique member ID for its associated dirty log, allowing multiple log services to coexist without sharing the same log and resolving performance/scalability issues. It modifies the Rust service to accept a my_member_id configuration, updates Kubernetes templates to wire this through pod metadata, sets the log filename accordingly, and scales out the number of service replicas in dev values.

Key Changes:
• Introduced my_member_id field to LogServerConfig in rust/log-service/src/lib.rs with default and serialization logic.
• Altered the log writer to use a distinct dirty log name per service instance based on my_member_id.
• Patched k8s StatefulSet template to inject pod metadata.name as CHROMA_QUERY_SERVICE__MY_MEMBER_ID via environment variables.
• Set rustLogService.replicaCount to 2 in values.dev.yaml to launch two log service replicas.
• Bumped Helm chart version from 0.1.40 to 0.1.41.

Affected Areas:
• rust/log-service configuration and log writer initialization
• Kubernetes statefulset and deployment logic
• Dev/test Helm chart configuration

This summary was automatically generated by @propel-code-bot

@github-actions
Copy link

✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to main.

@rescrv rescrv requested review from HammadB and codetheweb May 28, 2025 15:34
@rescrv rescrv merged commit 638fdcf into main May 28, 2025
72 checks passed
@rescrv rescrv deleted the rescrv/two-logs branch May 28, 2025 17:04
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
…a-core#4645)

## Description of changes

Putting two logs on the same dirty log wasn't incorrect but wasn't going
to perform.  This PR makes multiple log services possible now that the
frontend routes to them by collection ID.

This PR creates two rust-log-services and relies upon CI to uncover
problems.

## Test plan

CI

- [X] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants