Skip to content

Conversation

@codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jun 9, 2025

Description of changes

The wall time of Rust integration tests is now ~18m, down from ~22m.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the bld-separate-gc-proptest-job branch 2 times, most recently from 77d9364 to 40215b5 Compare June 9, 2025 22:06
@codetheweb codetheweb force-pushed the bld-separate-gc-proptest-job branch from 40215b5 to ee545fe Compare June 9, 2025 22:16
@codetheweb codetheweb marked this pull request as ready for review June 9, 2025 23:30
@codetheweb codetheweb requested a review from eculver June 9, 2025 23:30
@propel-code-bot
Copy link
Contributor

Separate Slow GC Integration Test into Distinct CI Job to Speed Up Rust Integration Tests

This PR restructures the Rust CI integration test workflow by isolating the slow 'test_k8s_integration_garbage_collection' test into its own matrix job using a new nextest profile (ci_k8s_integration_slow). The configuration ensures standard integration tests exclude this slow test, running it separately to reduce overall CI wall clock time from ~22m to ~18m. Related updates to .github/workflows/_rust-tests.yml and .config/nextest.toml streamline the partitioning and grouping of test execution.

Key Changes:
• Created a new ci_k8s_integration_slow nextest profile to run only the garbage collection integration test.
• Modified the ci_k8s_integration profile to exclude the GC test, allowing other integration tests to run concurrently.
• Updated the CI workflow (_rust-tests.yml) to include both fast and slow test profiles as distinct matrix entries, with proper partitioning strategy.
• Expanded naming and artifact conventions in integration test jobs for clarity.

Affected Areas:
• .github/workflows/_rust-tests.yml
• .config/nextest.toml

This summary was automatically generated by @propel-code-bot

Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These partitioning options are a little magical to me, but I'll take your word for it.

@codetheweb codetheweb merged commit be6a0e7 into main Jun 10, 2025
57 checks passed
@codetheweb codetheweb deleted the bld-separate-gc-proptest-job branch June 10, 2025 00:14
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

The wall time of Rust integration tests is now ~18m, down from ~22m.

## Test plan

_How are these changes tested?_

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants