[BLD]: use sccache during PyPi build #4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
This PR updates the PyPI build workflow to use sccache during the maturin Rust build step. The change reintroduces Rust build caching for performance by specifying 'sccache: true' in the relevant GitHub Actions step. This summary was automatically generated by @propel-code-bot |
codetheweb
added a commit
that referenced
this pull request
Jun 11, 2025
## Description of changes This was added in #4806, but it seems like the default sccache config doesn't work with Blacksmith. Disabling while we debug.
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
## Description of changes The PyPi build stopped being cached when the common Rust action switched to caching the target directory rather than going through sccache. This updates the maturin build step during PyPi release to use sccache for faster builds.
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
## Description of changes This was added in chroma-core#4806, but it seems like the default sccache config doesn't work with Blacksmith. Disabling while we debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The PyPi build stopped being cached when the common Rust action switched to caching the target directory rather than going through sccache. This updates the maturin build step during PyPi release to use sccache for faster builds.