-
Notifications
You must be signed in to change notification settings - Fork 2k
[CHORE] Add pprof server to query service #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to |
|
Add jemalloc pprof Server to Query Service for Memory Profiling This PR introduces support for starting a jemalloc-based pprof HTTP profiling server in the Chroma query-service, enabling memory profiling via Polar Signals or similar tooling. The addition is controlled via new configuration ( Key Changes• Added chroma-jemalloc-pprof-server as a dependency and integrated Affected Areas• rust/worker/src/server.rs (query service logic and initialization) This summary was automatically generated by @propel-code-bot |
## Description of changes Similar to what we did in #4845 and #5072, this adds the jemalloc pprof server to the compaction-service server so that we can do memory profiling for the service using Polar Signals. - New functionality - pprof server started when config given ## Test plan Build should succeed and updating chroma_config.yaml with local tilt environment to test that pprof endpoint is up.
## Description of changes Similar to what we did in #4845 and #5072, this adds the jemalloc pprof server to the compaction-service server so that we can do memory profiling for the service using Polar Signals. - New functionality - pprof server started when config given ## Test plan Build should succeed and updating chroma_config.yaml with local tilt environment to test that pprof endpoint is up.
## Description of changes Similar to what we did in chroma-core#4845, this adds the jemalloc pprof server to the query-service server so that we can do memory profiling for the service using Polar Signals. Note: I also updated a place in the garbage collector's implementation where the port was hard-coded to 6060. - New functionality - pprof server started when config given ## Test plan Build should succeed and updating `chroma_config.yaml` with local tilt environment to test that pprof endpoint is up. - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust
## Description of changes Similar to what we did in chroma-core#4845 and chroma-core#5072, this adds the jemalloc pprof server to the compaction-service server so that we can do memory profiling for the service using Polar Signals. - New functionality - pprof server started when config given ## Test plan Build should succeed and updating chroma_config.yaml with local tilt environment to test that pprof endpoint is up.
Description of changes
Similar to what we did in #4845, this adds the jemalloc pprof server to the query-service server so that we can do memory profiling for the service using Polar Signals.
Note: I also updated a place in the garbage collector's implementation where the port was hard-coded to 6060.
Test plan
Build should succeed and updating
chroma_config.yamlwith local tilt environment to test that pprof endpoint is up.pytestfor python,yarn testfor js,cargo testfor rust