Skip to content

Conversation

@Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Oct 27, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Bumping hnswlib to 0.8.2, which fixes an issue when max_elements is set to 0
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review October 27, 2025 23:12
@propel-code-bot
Copy link
Contributor

Bump hnswlib dependency to 0.8.2

This MINOR PR updates the project’s hnswlib crate from 0.8.1 to 0.8.2 across the workspace. The upstream release fixes a bug that occurred when max_elements was set to 0; no other source-code changes are introduced.

Key Changes

• Updated dependency line in Cargo.toml to hnswlib = { version = "0.8.2", git = "https://github.com/chroma-core/hnswlib.git", branch = "master" }
• Regenerated Cargo.lock to reflect hnswlib version 0.8.2 and new commit hash 312991c

Affected Areas

Cargo.toml (workspace dependency list)
Cargo.lock
• Build/dependency resolution pipeline

This summary was automatically generated by @propel-code-bot

@Sicheng-Pan Sicheng-Pan merged commit c26b0a8 into main Oct 28, 2025
64 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 10-27-_bld_bump_hnswlib_dep branch October 28, 2025 17:32
chroma-droid pushed a commit that referenced this pull request Oct 28, 2025
## Description of changes

_Summarize the changes made by this PR._

- Improvements & Bug fixes
- Bumping `hnswlib` to `0.8.2`, which fixes an issue when `max_elements`
is set to `0`
- New functionality
  - N/A

## Test plan

_How are these changes tested?_

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan

_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_

## Observability plan

_What is the plan to instrument and monitor this change?_

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sicheng-Pan added a commit that referenced this pull request Oct 28, 2025
This PR cherry-picks the commit c26b0a8
onto rc/2025-10-24. If there are unresolved conflicts, please resolve
them manually.

Co-authored-by: Macronova <[email protected]>
sanketkedia pushed a commit that referenced this pull request Oct 29, 2025
## Description of changes

_Summarize the changes made by this PR._

- Improvements & Bug fixes
- Bumping `hnswlib` to `0.8.2`, which fixes an issue when `max_elements`
is set to `0`
- New functionality
  - N/A

## Test plan

_How are these changes tested?_

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan

_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_

## Observability plan

_What is the plan to instrument and monitor this change?_

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants