Skip to content

Commit c15a412

Browse files
aelioxoctoperalexcarpenter
authored
chore(clerk-js,types,localizations): New layout for PricingTable plan cards (#5824)
Co-authored-by: Vaggelis Yfantis <me@octoper.me> Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com> Co-authored-by: Alex Carpenter <alex.carpenter@clerk.dev>
1 parent 17397f9 commit c15a412

File tree

14 files changed

+315
-200
lines changed

14 files changed

+315
-200
lines changed

.changeset/old-cobras-change.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@clerk/localizations': patch
3+
'@clerk/clerk-js': patch
4+
'@clerk/types': patch
5+
---
6+
7+
Adjusts the layout of the `PricingTable` plan cards

integration/tests/pricing-table.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing tabl
2828
await expect(u.po.page.getByRole('heading', { name: 'Pro' })).toBeVisible();
2929
});
3030

31-
test('when signed out, clicking get started button navigates to sign in page', async ({ page, context }) => {
31+
test('when signed out, clicking subscribe button navigates to sign in page', async ({ page, context }) => {
3232
const u = createTestUtils({ app, page, context });
3333
await u.po.page.goToRelative('/pricing-table');
3434

@@ -101,7 +101,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing tabl
101101
await u.po.pricingTable.clickManageSubscription();
102102
await u.po.page.getByRole('button', { name: 'Cancel subscription' }).click();
103103
await u.po.page.getByRole('alertdialog').getByRole('button', { name: 'Cancel subscription' }).click();
104-
await expect(u.po.page.getByRole('button', { name: 'Re-subscribe' }).first()).toBeVisible();
104+
await expect(u.po.page.getByRole('button', { name: /resubscribe|re-subscribe/i }).first()).toBeVisible();
105105
});
106106

107107
test.describe('in UserProfile', () => {

packages/clerk-js/bundlewatch.config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{ "path": "./dist/clerk.browser.js", "maxSize": "68KB" },
55
{ "path": "./dist/clerk.legacy.browser.js", "maxSize": "110KB" },
66
{ "path": "./dist/clerk.headless*.js", "maxSize": "52KB" },
7-
{ "path": "./dist/ui-common*.js", "maxSize": "102.5KB" },
7+
{ "path": "./dist/ui-common*.js", "maxSize": "104KB" },
88
{ "path": "./dist/vendors*.js", "maxSize": "39KB" },
99
{ "path": "./dist/coinbase*.js", "maxSize": "38KB" },
1010
{ "path": "./dist/createorganization*.js", "maxSize": "5KB" },

0 commit comments

Comments
 (0)