Skip to content

Commit c5c246c

Browse files
authored
feat(clerk-js): Handle new session pending status as authenticated state (#5136)
1 parent bcbe5f6 commit c5c246c

File tree

30 files changed

+627
-483
lines changed

30 files changed

+627
-483
lines changed

.changeset/nasty-mangos-live.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
'@clerk/elements': minor
3+
'@clerk/shared': minor
4+
'@clerk/astro': minor
5+
'@clerk/clerk-react': minor
6+
'@clerk/types': minor
7+
'@clerk/clerk-expo': minor
8+
'@clerk/vue': minor
9+
---
10+
11+
Surface new `pending` session as a signed-in state

.changeset/proud-cycles-roll.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
'@clerk/clerk-js': minor
3+
---
4+
5+
- Initialize new `pending` session status as an signed-in state
6+
- Deprecate `Clerk.client.activeSessions` in favor of `Clerk.client.signedInSessions`
7+
- Introduce `Clerk.isSignedIn` property as an explicit signed-in state check, instead of `!!Clerk.session` or `!!Clerk.user`:
8+
9+
```ts
10+
- if (Clerk.user) {
11+
+ if (Clerk.isSignedIn) {
12+
// Mount user button component
13+
document.getElementById('signed-in').innerHTML = `
14+
<div id="user-button"></div>
15+
`
16+
17+
const userbuttonDiv = document.getElementById('user-button')
18+
19+
clerk.mountUserButton(userbuttonDiv)
20+
}

packages/astro/src/stores/internal.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import type {
2-
ActiveSessionResource,
32
Clerk,
43
ClientResource,
54
InitialState,
65
OrganizationResource,
6+
SignedInSessionResource,
77
UserResource,
88
} from '@clerk/types';
99
import { atom, map } from 'nanostores';
@@ -12,7 +12,7 @@ export const $csrState = map<{
1212
isLoaded: boolean;
1313
client: ClientResource | undefined | null;
1414
user: UserResource | undefined | null;
15-
session: ActiveSessionResource | undefined | null;
15+
session: SignedInSessionResource | undefined | null;
1616
organization: OrganizationResource | undefined | null;
1717
}>({
1818
isLoaded: false,

packages/clerk-js/src/core/__tests__/clerk.redirects.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ describe('Clerk singleton - Redirects', () => {
9191
beforeEach(() => {
9292
mockClientFetch.mockReturnValue(
9393
Promise.resolve({
94-
activeSessions: [],
94+
signedInSessions: [],
9595
}),
9696
);
9797
});

0 commit comments

Comments
 (0)