Adding support for buttons that live outside of their form, and instead specify a form attribute

Author: theunraveler

splinter/driver/lxmldriver.py

@@ -439,7 +439,13 @@ def select(self, value):
         self._control.value = value
 
     def _get_parent_form(self):
-        parent_form = next(self._control.iterancestors("form"))
+        # First, try to find the form by the `form` attribute.
+        if 'form' in self._control.attrib:
+            parent_form = self._control.getroottree().xpath(
+                '//*[@id="%s"][1]' % self._control.attrib['form']
+            )[0]
+        else:
+            parent_form = next(self._control.iterancestors("form"))
         return self.parent._forms.setdefault(parent_form._name(), parent_form)
 
 

tests/form_elements.py

@@ -89,6 +89,13 @@ def test_clicking_submit_button_posts_button_value_if_value_present(self):
             "submit-button: submit-button-value",
         )
 
+    def test_submitting_a_form_when_the_button_is_outside_the_form(self):
+        self.browser.find_by_css('input[form="form-with-submit-outside"]').click()
+        self.assertEqual(
+            self.browser.find_by_xpath("/descendant-or-self::*").text,
+            "submit-input: submit-input-value",
+        )
+
     def test_submiting_a_form_and_verifying_page_content(self):
         self.browser.fill("query", "my name")
         self.browser.find_by_name("send").click()

tests/static/index.html

@@ -142,6 +142,9 @@ <h1 id="firstheader">Example Last Header</h1>
       <input type="text" name="lastname">
     </form>
 
+    <form action="/post" method="POST" id="form-with-submit-outside">
+    </form>
+    <input type="submit" form="form-with-submit-outside" name="submit-input" value="submit-input-value" />
 
     <a href="http://example.com/">Link for Example.com</a>
     <a href="http://example.com/last">Link for Example.com</a>