[OPIK-5206] [BE] feat: add V1 entity check for alerts in workspace version (#5975)

* [OPIK-5206] [BE] feat: add V1 entity check for alerts in workspace version

Add alerts to the workspace version V1 entity check. Alerts without
project_id (workspace-level) now signal VERSION_1. Project-scoped
alerts do not trigger V1.

* test(auth): address PR #5964 review feedback from thiagohora

- Add comments explaining the serialize→Map→override→re-serialize
  pattern in testAuthSuccessful/testSessionAuthSuccessful (bypasses
  @jsonvalue to inject raw strings like "VERSION_1", "version_unknown")

Author: andrescrz

apps/opik-backend/src/main/java/com/comet/opik/domain/AlertDAO.java

@@ -45,7 +45,7 @@
 @RegisterColumnMapper(MapFlatArgumentFactory.class)
 @RegisterArgumentFactory(AlertTypeArgumentFactory.class)
 @RegisterColumnMapper(AlertTypeColumnMapper.class)
-interface AlertDAO {
+public interface AlertDAO {
 
     String FIND = """
             WITH target_alerts AS (
@@ -140,6 +140,9 @@ INSERT INTO alerts (id, name, enabled, alert_type, metadata, webhook_id, workspa
     void save(@Bind("workspaceId") String workspaceId, @BindMethods("bean") Alert alert,
             @Bind("webhookId") UUID webhookId);
 
+    @SqlQuery("SELECT EXISTS(SELECT 1 FROM alerts WHERE workspace_id = :workspaceId AND project_id IS NULL)")
+    boolean hasVersion1Alerts(@Bind("workspaceId") String workspaceId);
+
     @SqlQuery(FIND)
     @UseStringTemplateEngine
     @AllowUnusedBindings

apps/opik-backend/src/main/java/com/comet/opik/domain/workspaces/WorkspaceVersionService.java

@@ -2,6 +2,7 @@
 
 import com.comet.opik.api.OpikVersion;
 import com.comet.opik.api.WorkspaceVersion;
+import com.comet.opik.domain.AlertDAO;
 import com.comet.opik.domain.DashboardDAO;
 import com.comet.opik.domain.DatasetDAO;
 import com.comet.opik.domain.DemoData;
@@ -211,7 +212,10 @@ private boolean hasStateDbVersion1Entities(String workspaceId) {
                 log.info("Found version_1 datasets in workspace '{}'", workspaceId);
                 return true;
             }
-            // TODO: alerts — no project_id column yet. Skipped until column is added.
+            if (handle.attach(AlertDAO.class).hasVersion1Alerts(workspaceId)) {
+                log.info("Found version_1 alerts in workspace '{}'", workspaceId);
+                return true;
+            }
             return false;
         });
     }

apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/AlertResourceTest.java

@@ -2839,7 +2839,11 @@ private void compareAlerts(Alert expected, Alert actual, boolean decryptSecretTo
     }
 
     private Alert generateAlert() {
-        var alert = factory.manufacturePojo(Alert.class);
+        return generateAlert(factory);
+    }
+
+    static Alert generateAlert(PodamFactory podamFactory) {
+        var alert = podamFactory.manufacturePojo(Alert.class);
 
         var webhook = alert.webhook().toBuilder()
                 .createdBy(null)
@@ -2851,7 +2855,7 @@ private Alert generateAlert() {
                 .map(trigger -> {
                     var configs = Optional.ofNullable(trigger.triggerConfigs())
                             .map(list -> list.stream()
-                                    .map(this::sanitizeTriggerConfig)
+                                    .map(AlertResourceTest::sanitizeTriggerConfig)
                                     .toList())
                             .orElse(null);
                     // Replace TRACE_COST and TRACE_LATENCY with TRACE_ERRORS for test assertion purposes
@@ -2877,7 +2881,7 @@ private Alert generateAlert() {
                 .build();
     }
 
-    private AlertTriggerConfig sanitizeTriggerConfig(AlertTriggerConfig config) {
+    private static AlertTriggerConfig sanitizeTriggerConfig(AlertTriggerConfig config) {
         var builder = config.toBuilder()
                 .createdBy(null)
                 .createdAt(null);
@@ -2887,14 +2891,18 @@ private AlertTriggerConfig sanitizeTriggerConfig(AlertTriggerConfig config) {
             var fixedConfigValue = new HashMap<>(config.configValue());
             fixedConfigValue.put(
                     AlertTriggerConfig.PROJECT_IDS_CONFIG_KEY,
-                    JsonUtils.writeValueAsString(List.of(factory.manufacturePojo(UUID.class))));
+                    JsonUtils.writeValueAsString(List.of(UUID.randomUUID())));
             builder.configValue(fixedConfigValue);
         }
         return builder.build();
     }
 
     private Alert generateAlertForProject(UUID projectId) {
-        var base = generateAlert();
+        return generateAlertForProject(factory, projectId);
+    }
+
+    static Alert generateAlertForProject(PodamFactory podamFactory, UUID projectId) {
+        var base = generateAlert(podamFactory);
         var filteredTriggers = base.triggers().stream()
                 .map(t -> t.toBuilder()
                         .triggerConfigs(t.triggerConfigs().stream()

apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/WorkspaceVersionResourceTest.java

@@ -16,6 +16,7 @@
 import com.comet.opik.api.resources.utils.TestDropwizardAppExtensionUtils.CustomConfig;
 import com.comet.opik.api.resources.utils.TestUtils;
 import com.comet.opik.api.resources.utils.WireMockUtils;
+import com.comet.opik.api.resources.utils.resources.AlertResourceClient;
 import com.comet.opik.api.resources.utils.resources.AutomationRuleEvaluatorResourceClient;
 import com.comet.opik.api.resources.utils.resources.DashboardResourceClient;
 import com.comet.opik.api.resources.utils.resources.DatasetResourceClient;
@@ -219,6 +220,7 @@ class EntityWorkspaceVersionTest {
         private AutomationRuleEvaluatorResourceClient evaluatorClient;
         private ExperimentResourceClient experimentClient;
         private OptimizationResourceClient optimizationClient;
+        private AlertResourceClient alertClient;
 
         @BeforeAll
         void beforeAll(ClientSupport clientSupport) {
@@ -231,6 +233,7 @@ void beforeAll(ClientSupport clientSupport) {
             evaluatorClient = new AutomationRuleEvaluatorResourceClient(clientSupport, baseUrl);
             experimentClient = new ExperimentResourceClient(clientSupport, baseUrl, podamFactory);
             optimizationClient = new OptimizationResourceClient(clientSupport, baseUrl, podamFactory);
+            alertClient = new AlertResourceClient(clientSupport);
         }
 
         @AfterAll
@@ -385,6 +388,23 @@ void workspaceVersion__whenOptimizationWithoutProject__returnsVersion1() {
                     API_KEY, workspaceName);
             assertThat(workspaceClient.getWorkspaceVersion(API_KEY, workspaceName)).isEqualTo(V1_WORKSPACE_VERSION);
         }
+
+        @Test
+        void workspaceVersion__whenAlertWithoutProject__returnsVersion1() {
+            var workspaceName = mockWorkspace();
+
+            // Project-scoped alert (projectId column) does not trigger version_1
+            alertClient.createAlert(
+                    AlertResourceTest.generateAlertForProject(podamFactory, UUID.randomUUID()),
+                    API_KEY, workspaceName, 201);
+            assertThat(workspaceClient.getWorkspaceVersion(API_KEY, workspaceName)).isEqualTo(V2_WORKSPACE_VERSION);
+
+            // Workspace level alert triggers version_1
+            alertClient.createAlert(
+                    AlertResourceTest.generateAlert(podamFactory),
+                    API_KEY, workspaceName, 201);
+            assertThat(workspaceClient.getWorkspaceVersion(API_KEY, workspaceName)).isEqualTo(V1_WORKSPACE_VERSION);
+        }
     }
 
     @Nested

apps/opik-backend/src/test/java/com/comet/opik/infrastructure/auth/RemoteAuthServiceTest.java

@@ -106,6 +106,8 @@ void testAuthSuccessful(boolean workspaceViaHeader, String opikVersionStr)
         var apiKey = "apiKey-" + UUID.randomUUID();
         var workspaceName = "workspace-" + UUID.randomUUID();
 
+        // Serialize via Map to inject the raw opikVersionStr (e.g. "VERSION_1", "version_unknown")
+        // directly into JSON, bypassing @JsonValue which would normalize the casing
         Map<String, Object> responseMap = OBJECT_MAPPER.readValue(
                 OBJECT_MAPPER.writeValueAsString(authResponse), Map.class);
         responseMap.put("opikVersion", opikVersionStr);
@@ -247,6 +249,7 @@ void testSessionAuthSuccessful(boolean workspaceViaHeader, String opikVersionStr
         var sessionTokenValue = "session-" + UUID.randomUUID();
         var workspaceName = "workspace-" + UUID.randomUUID();
 
+        // Serialize via Map to inject raw opikVersionStr, bypassing @JsonValue normalization
         Map<String, Object> responseMap = OBJECT_MAPPER.readValue(
                 OBJECT_MAPPER.writeValueAsString(authResponse), Map.class);
         responseMap.put("opikVersion", opikVersionStr);