Skip to content

Commit f681bf7

Browse files
committed
[OPIK-4972] [SDK] Fix test_success to handle category_name absent or None
opik 1.10.56 added category_name to ScoreResult but the Docker image in CI may use an older opik version without it. Assert category_name is None when present and compare remaining fields, so both executor variants pass.
1 parent 0bf6149 commit f681bf7

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

apps/opik-python-backend/tests/test_evaluator_python.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ def error_response(*args, **kwargs):
228228
USER_DEFINED_METRIC,
229229
[
230230
{
231-
"category_name": None,
232231
"metadata": None,
233232
"name": 'user_defined_equals_metric',
234233
"reason": None,
@@ -242,7 +241,6 @@ def error_response(*args, **kwargs):
242241
USER_DEFINED_METRIC,
243242
[
244243
{
245-
"category_name": None,
246244
"metadata": None,
247245
"name": 'user_defined_equals_metric',
248246
"reason": None,
@@ -256,15 +254,13 @@ def error_response(*args, **kwargs):
256254
LIST_RESPONSE_METRIC,
257255
[
258256
{
259-
"category_name": None,
260257
"metadata": None,
261258
"name": 'user_defined_list_equals_metric',
262259
"reason": None,
263260
"scoring_failed": False,
264261
"value": 1.0
265262
},
266263
{
267-
"category_name": None,
268264
"metadata": None,
269265
"name": 'user_defined_list_equals_metric',
270266
"reason": None,
@@ -281,7 +277,9 @@ def test_success(client, data, code, expected):
281277
})
282278

283279
assert response.status_code == 200
284-
assert response.json['scores'] == expected
280+
scores = response.json['scores']
281+
assert all(s.get('category_name') is None for s in scores)
282+
assert [{k: v for k, v in s.items() if k != 'category_name'} for s in scores] == expected
285283

286284

287285
def test_options_method_returns_ok(client):

0 commit comments

Comments
 (0)