Remove redundant as_handle helper

windows-sys has long ago switched to matching the standard library's HANDLE type

Author: ChrisDenton

src/windows_term/mod.rs

@@ -36,11 +36,6 @@ pub(crate) use self::colors::*;
 
 pub(crate) const DEFAULT_WIDTH: u16 = 79;
 
-pub(crate) fn as_handle(term: &Term) -> HANDLE {
-    // convert between windows_sys::Win32::Foundation::HANDLE and std::os::windows::raw::HANDLE
-    term.as_raw_handle() as HANDLE
-}
-
 pub(crate) fn is_a_terminal(out: &Term) -> bool {
     let (fd, others) = match out.target() {
         TermTarget::Stdout => (STD_OUTPUT_HANDLE, [STD_INPUT_HANDLE, STD_ERROR_HANDLE]),
@@ -196,7 +191,7 @@ pub(crate) fn move_cursor_to(out: &Term, x: usize, y: usize) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::move_cursor_to(out, x, y);
     }
-    if let Some((hand, _)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((hand, _)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         unsafe {
             SetConsoleCursorPosition(
                 hand,
@@ -215,7 +210,7 @@ pub(crate) fn move_cursor_up(out: &Term, n: usize) -> io::Result<()> {
         return common_term::move_cursor_up(out, n);
     }
 
-    if let Some((_, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((_, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         move_cursor_to(out, 0, csbi.dwCursorPosition.Y as usize - n)?;
     }
     Ok(())
@@ -226,7 +221,7 @@ pub(crate) fn move_cursor_down(out: &Term, n: usize) -> io::Result<()> {
         return common_term::move_cursor_down(out, n);
     }
 
-    if let Some((_, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((_, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         move_cursor_to(out, 0, csbi.dwCursorPosition.Y as usize + n)?;
     }
     Ok(())
@@ -237,7 +232,7 @@ pub(crate) fn move_cursor_left(out: &Term, n: usize) -> io::Result<()> {
         return common_term::move_cursor_left(out, n);
     }
 
-    if let Some((_, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((_, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         move_cursor_to(
             out,
             csbi.dwCursorPosition.X as usize - n,
@@ -252,7 +247,7 @@ pub(crate) fn move_cursor_right(out: &Term, n: usize) -> io::Result<()> {
         return common_term::move_cursor_right(out, n);
     }
 
-    if let Some((_, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((_, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         move_cursor_to(
             out,
             csbi.dwCursorPosition.X as usize + n,
@@ -266,7 +261,7 @@ pub(crate) fn clear_line(out: &Term) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::clear_line(out);
     }
-    if let Some((hand, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((hand, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         unsafe {
             let width = csbi.srWindow.Right - csbi.srWindow.Left;
             let pos = COORD {
@@ -286,7 +281,7 @@ pub(crate) fn clear_chars(out: &Term, n: usize) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::clear_chars(out, n);
     }
-    if let Some((hand, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((hand, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         unsafe {
             let width = cmp::min(csbi.dwCursorPosition.X, n as i16);
             let pos = COORD {
@@ -306,7 +301,7 @@ pub(crate) fn clear_screen(out: &Term) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::clear_screen(out);
     }
-    if let Some((hand, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((hand, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         unsafe {
             let cells = csbi.dwSize.X as u32 * csbi.dwSize.Y as u32; // as u32, or else this causes stack overflows.
             let pos = COORD { X: 0, Y: 0 };
@@ -323,7 +318,7 @@ pub(crate) fn clear_to_end_of_screen(out: &Term) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::clear_to_end_of_screen(out);
     }
-    if let Some((hand, csbi)) = get_console_screen_buffer_info(as_handle(out)) {
+    if let Some((hand, csbi)) = get_console_screen_buffer_info(out.as_raw_handle()) {
         unsafe {
             let bottom = csbi.srWindow.Right as u32 * csbi.srWindow.Bottom as u32;
             let cells = bottom - (csbi.dwCursorPosition.X as u32 * csbi.dwCursorPosition.Y as u32); // as u32, or else this causes stack overflows.
@@ -344,7 +339,7 @@ pub(crate) fn show_cursor(out: &Term) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::show_cursor(out);
     }
-    if let Some((hand, mut cci)) = get_console_cursor_info(as_handle(out)) {
+    if let Some((hand, mut cci)) = get_console_cursor_info(out.as_raw_handle()) {
         unsafe {
             cci.bVisible = 1;
             SetConsoleCursorInfo(hand, &cci);
@@ -357,7 +352,7 @@ pub(crate) fn hide_cursor(out: &Term) -> io::Result<()> {
     if out.is_msys_tty {
         return common_term::hide_cursor(out);
     }
-    if let Some((hand, mut cci)) = get_console_cursor_info(as_handle(out)) {
+    if let Some((hand, mut cci)) = get_console_cursor_info(out.as_raw_handle()) {
         unsafe {
             cci.bVisible = 0;
             SetConsoleCursorInfo(hand, &cci);