Resolve toFixed errors in viewport overlay after dcmjs server changes#115
Merged
swederik merged 1 commit intocornerstonejs:masterfrom Mar 11, 2021
Merged
Conversation
Contributor
igoroctaviano
commented
Mar 11, 2021
igoroctaviano
commented
- OHIF issue #2297
swederik
approved these changes
Mar 11, 2021
Member
swederik
left a comment
swederik
left a comment
There was a problem hiding this comment.
This is probably fine for now because I can imaging people providing either to this component, but i would think it would be better to parse it to a number at the OHIF level
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.