Skip to content

Commit de906b1

Browse files
cortinicofacebook-github-bot
authored andcommitted
Fix per-tap OkHttpClient allocation in RedBoxContentView (facebook#55578)
Summary: RedBoxContentView.OpenStackFrameTask was creating a new OkHttpClient() (with a fresh connection pool and thread pool) every time a user tapped a stack frame in the red box. Replace with the shared DevSupportHttpClient.httpClient singleton. Changelog: [Internal] Differential Revision: D93480250
1 parent ede314e commit de906b1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxContentView.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ import android.widget.TextView
3333
import com.facebook.common.logging.FLog
3434
import com.facebook.react.R
3535
import com.facebook.react.common.ReactConstants
36+
import com.facebook.react.devsupport.inspector.DevSupportHttpClient
3637
import com.facebook.react.devsupport.interfaces.DevSupportManager
3738
import com.facebook.react.devsupport.interfaces.ErrorType
3839
import com.facebook.react.devsupport.interfaces.RedBoxHandler
3940
import com.facebook.react.devsupport.interfaces.StackFrame
4041
import okhttp3.MediaType
41-
import okhttp3.OkHttpClient
4242
import okhttp3.Request
4343
import okhttp3.RequestBody
4444
import org.json.JSONObject
@@ -165,7 +165,7 @@ internal class RedBoxContentView(
165165
.query(null)
166166
.build()
167167
.toString()
168-
val client = OkHttpClient()
168+
val client = DevSupportHttpClient.httpClient
169169
for (frame in stackFrames) {
170170
val payload = stackFrameToJson(checkNotNull(frame)).toString()
171171
val body: RequestBody = RequestBody.create(JSON, payload)

0 commit comments

Comments
 (0)