test: make tests pass when configured without-ssl

Currently when node is build --without-ssl and the test are run,
there are a number of failing test due to tests expecting crypto
support to be available. This commit fixes fixes the failure and
instead skips the tests that expect crypto to be available.

PR-URL: nodejs#11631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

Author: danbev

test/addons/openssl-binding/binding.gyp

@@ -2,8 +2,12 @@
   'targets': [
     {
       'target_name': 'binding',
-      'sources': ['binding.cc'],
-      'include_dirs': ['../../../deps/openssl/openssl/include'],
+      'conditions': [
+         ['node_use_openssl=="true"', {
+           'sources': ['binding.cc'],
+           'include_dirs': ['../../../deps/openssl/openssl/include'],
+         }]
+      ]
     },
   ]
 }

test/addons/openssl-binding/test.js

@@ -1,6 +1,10 @@
 'use strict';
 
 const common = require('../../common');
+if (!common.hasCrypto) {
+  common.skip('missing crypto');
+  process.exit(0);
+}
 const assert = require('assert');
 const binding = require(`./build/${common.buildType}/binding`);
 const bytes = new Uint8Array(1024);

test/common.js

@@ -614,3 +614,10 @@ exports.expectsError = function expectsError({code, type, message}) {
     return true;
   };
 };
+
+exports.skipIfInspectorDisabled = function skipIfInspectorDisabled() {
+  if (!exports.hasCrypto) {
+    exports.skip('missing ssl support so inspector is disabled');
+    process.exit(0);
+  }
+};

test/fixtures/tls-connect.js

@@ -6,19 +6,15 @@
 const common = require('../common');
 const fs = require('fs');
 const join = require('path').join;
+// Check if Node was compiled --without-ssl and if so exit early
+// as the require of tls will otherwise throw an Error.
+if (!common.hasCrypto) {
+  common.skip('missing crypto');
+  process.exit(0);
+}
 const tls = require('tls');
 const util = require('util');
 
-module.exports = exports = checkCrypto;
-
-function checkCrypto() {
-  if (!common.hasCrypto) {
-    common.skip('missing crypto');
-    process.exit(0);
-  }
-  return exports;
-}
-
 exports.assert = require('assert');
 exports.debug = util.debuglog('test');
 exports.tls = tls;

test/inspector/test-inspector.js

@@ -1,5 +1,6 @@
 'use strict';
-require('../common');
+const common = require('../common');
+common.skipIfInspectorDisabled();
 const assert = require('assert');
 const helper = require('./inspector-helper.js');
 

test/inspector/test-not-blocked-on-idle.js

@@ -1,5 +1,6 @@
 'use strict';
-require('../common');
+const common = require('../common');
+common.skipIfInspectorDisabled();
 const helper = require('./inspector-helper.js');
 
 function shouldShutDown(session) {

test/parallel/test-cluster-inspector-debug-port.js

@@ -1,6 +1,7 @@
 'use strict';
 // Flags: --inspect={PORT}
 const common = require('../common');
+common.skipIfInspectorDisabled();
 const assert = require('assert');
 const cluster = require('cluster');
 const debuggerPort = common.PORT;

test/parallel/test-tls-addca.js

@@ -8,7 +8,7 @@ const common = require('../common');
 const join = require('path').join;
 const {
   assert, connect, keys, tls
-} = require(join(common.fixturesDir, 'tls-connect'))();
+} = require(join(common.fixturesDir, 'tls-connect'));
 
 const contextWithoutCert = tls.createSecureContext({});
 const contextWithCert = tls.createSecureContext({});

test/parallel/test-tls-ca-concat.js

@@ -7,7 +7,7 @@ const common = require('../common');
 const join = require('path').join;
 const {
   assert, connect, keys
-} = require(join(common.fixturesDir, 'tls-connect'))();
+} = require(join(common.fixturesDir, 'tls-connect'));
 
 connect({
   client: {

test/parallel/test-tls-cert-chains-concat.js

@@ -7,7 +7,7 @@ const common = require('../common');
 const join = require('path').join;
 const {
   assert, connect, debug, keys
-} = require(join(common.fixturesDir, 'tls-connect'))();
+} = require(join(common.fixturesDir, 'tls-connect'));
 
 // agent6-cert.pem includes cert for agent6 and ca3
 connect({