-
Notifications
You must be signed in to change notification settings - Fork 838
feat(function): implement pivot and unpivot #10676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
# Conflicts: # src/query/ast/src/parser/token.rs
sundy-li
reviewed
Mar 20, 2023
b41sh
reviewed
Mar 21, 2023
sundy-li
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Syntax
The basic syntax of pivot and unpivot is currently supported:
pivot:
group byis optional, by default this is all columns not mentioned in the above clausesunpivot:
Implement
Like duckdb, pivoting and unpivoting are implemented entirely as rewrites into SQL queries. Specifically, it is implemented by rewriting
SelectStmtin the bind stage.Now unpivot works fine, pivot results are the same as equivalent SQL statements, but due to agg_if implementation seems to have bugs, pivot results are not correct.
For example,the following two statements are equivalent:
Their results of them are indeed the same, but they are not correct:
Closes #10498