fix: fix memory_size of sliced string view. #19014
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
youngsofun
changed the title
youngsofun
force-pushed
the
mem
branch
2 times, most recently
from
a82c847 to
ccabe90
Compare
youngsofun
force-pushed
the
mem
branch
2 times, most recently
from
c894e2c to
caecdd4
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…)" This reverts commit 8b4a558.
3 participants
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
before this pr, memory_size rely on total_buffer_len, which is not changed when sliced.
after this pr memory_size is fixed so it only counts for the part it owned. sum of memory_size of a splitted block is eq to the origin memory_size.
if we do need the memory_size of the underly data buffer, we may need a new function or arg.
new impl also consider the size of reading column back from parquet. parquet use a simple bytes array without view.
the buffer of the bytes array is used directly as buffer of view
Tests
Type of change
This change is