Skip to content

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 1, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR improve explain perf in the following aspects:

  1. Mark inlined functions with (inlined) suffix
image image
  1. Remove frames introduced by pprof's own stack collection

remove this:
image

  1. use frames_post_processor to rewrite the frames instead of changing in upstream: datafuse-extras/pprof-rs@edecd74

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (improve display):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 1, 2025
@dqhl76 dqhl76 marked this pull request as ready for review December 1, 2025 08:00
@dqhl76 dqhl76 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Docker Image for PR

  • tag: pr-19042-916bd07-1764582293

note: this image tag is only available for internal use.

@dqhl76 dqhl76 marked this pull request as draft December 1, 2025 10:28
@dqhl76 dqhl76 added the ci-cloud Build docker image for cloud test label Dec 1, 2025
@dqhl76 dqhl76 marked this pull request as ready for review December 2, 2025 01:08
@dqhl76 dqhl76 requested review from everpcpc and zhang2014 December 2, 2025 01:08
@dqhl76
Copy link
Collaborator Author

dqhl76 commented Dec 2, 2025

pull_request_target will always use main branch's action files, so I will reopen a PR to test it on cloud.

@everpcpc
Copy link
Member

everpcpc commented Dec 2, 2025

You'll need to change the actions files in another PR and merge it first.

@dqhl76 dqhl76 marked this pull request as draft December 2, 2025 02:04
@dqhl76 dqhl76 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Docker Image for PR

  • tag: pr-19042-c9e68de-1764647043

note: this image tag is only available for internal use.

@dqhl76 dqhl76 marked this pull request as ready for review December 2, 2025 04:52
@dqhl76
Copy link
Collaborator Author

dqhl76 commented Dec 2, 2025

perf.html

image

For now, we can see inlined flag on cloud build.

@zhang2014 zhang2014 merged commit 3cbcfcc into databendlabs:main Dec 2, 2025
193 of 197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants