fix: catch UncheckedExecutionException on docker exec #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utable isn't found in path
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
See: https://php-perfect.sentry.io/issues/6547707863/
Currently, and UncheckedExecutionException is being thrown when the docker executable isn't found. This should instead be caught the same as other types of command execution exceptions.
How this PR Solves the Problem:
Catch UncheckedExecutionException in DockerImpl
Manual Testing Instructions:
Related Issue Link(s):
WIP
Actually, this should either be using the remote settings to find the correct docker exec path, or not rely on docker itself anymore.