feat: DH-21259: Add map_style to theme#2605
Merged
jnumainville merged 2 commits intodeephaven:mainfrom Jan 12, 2026
Merged
Conversation
mofojed
requested changes
Jan 12, 2026
Member
mofojed
left a comment
There was a problem hiding this comment.
Looks good. Updates when changing the theme too, nice.
Fix up the unit tests first, may just need to update the snapshots. To do that, run npm test, then it'll say 2 tests failed because of snapshots, press u to update failing snapshots.
Pretty sure it's just the added map style property that's causing it to fail.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
- Coverage 45.71% 45.71% -0.01%
==========================================
Files 771 771
Lines 43649 43652 +3
Branches 11046 11231 +185
==========================================
Hits 19954 19954
- Misses 23678 23681 +3
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't really block deephaven/deephaven-plugins#1279 but is used for it.
I do think it's best to allow anyone to override the
map_stylein the theme if we want it to be allowed in the theme, although this method is a bit wonky so I'm not sure if it's the best way to do it.