fix: DH-21407: Dehydrate/hydrate pending data correctly#2606
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jan 16, 2026
Merged
fix: DH-21407: Dehydrate/hydrate pending data correctly#2606mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Jan 14, 2026
- We were tryin to dehydrate the CellData object instead of the value itself
- Just dehydrate the value itself
- Fix the tests
- This seems to have been broken for a long time, and only now it's being caught when attempting to persist deephaven.ui data
- We were tryin to dehydrate the CellData object instead of the value itself - Just dehydrate the value itself - Fix the tests - This seems to have been broken for a long time, and only now it's being caught when attempting to persist deephaven.ui data
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
==========================================
+ Coverage 45.71% 45.96% +0.25%
==========================================
Files 771 771
Lines 43652 43652
Branches 11231 11231
==========================================
+ Hits 19954 20065 +111
+ Misses 23653 23570 -83
+ Partials 45 17 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.