Skip to content

fix: DH-21696: Fixed broken frozen columns#2649

Merged
mofojed merged 1 commit intodeephaven:mainfrom
bmingles:DH-21696_freeze-columns
Apr 1, 2026
Merged

fix: DH-21696: Fixed broken frozen columns#2649
mofojed merged 1 commit intodeephaven:mainfrom
bmingles:DH-21696_freeze-columns

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Apr 1, 2026

DH-21696: A default prop value was changed from null to EMPTY_ARRAY in https://github.com/deephaven/web-client-ui/pull/2527/changes#diff-ba5d5bc0271a84729ec1bd28c11b7e1f05b3e71e4015c0bea863b4bf52b85bd8R544 . This was breaking a coalesce in IrisGridTableModel.getMemoizedFrozenColumns(). Fix was to set default to undefined

Testing

Freezing columns via dh.ui should actually freeze the columns:

from deephaven import ui
import deephaven.plot.express as dx

t1 = dx.data.stocks()

t2 = ui.table(
    t1,
    frozen_columns=["Sym", "Exchange"]
)

@bmingles bmingles requested a review from mattrunyon April 1, 2026 17:28
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.51%. Comparing base (a0ef312) to head (696fa21).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
- Coverage   49.77%   49.51%   -0.27%     
==========================================
  Files         774      774              
  Lines       43860    43871      +11     
  Branches    11291    11109     -182     
==========================================
- Hits        21832    21723     -109     
- Misses      22010    22130     +120     
  Partials       18       18              
Flag Coverage Δ
unit 49.51% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed enabled auto-merge (squash) April 1, 2026 20:25
@mofojed mofojed merged commit b6edd2d into deephaven:main Apr 1, 2026
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants