Fix preview seek times in cut mode #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On changing the cut-from and cut-to times using the RangeSlider, the player seeks to the cut-from time or 1.5s before the cut-to time. However, the seek timestamps (already in milliseconds) were multiplied with 1000 another time, resulting in the preview seeking to the end of the video and restarting from the cut-from time.
Also, I have changed the detection whether the cut-from or cut-to slider was dragged to use
rangeSlider.focusedThumbIndexwhich to me seems more straightforward than comparing the textinput contents. This should also fix the edge case when the cut-to slider is dragged, but ends up in the exact same time as when it started.