-
Notifications
You must be signed in to change notification settings - Fork 689
handle no default attestations env var #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
93d7ffa to
515158f
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
515158f to
1c198f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tonistiigi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the issue that env is not propagated to buildx or does this need custom handling? If former then maybe a better fix would be to just make sure all BUILDX_* env are forwarded.
Yes it needs custom handling because the action is setting the provenance based on github events: build-push-action/src/context.ts Lines 248 to 260 in c566248
|
Closes #820 *(description copied from #820 (comment) `build-*-manifest` CI jobs are failing like this: ```text docker.io/rapidsai/staging:docker-cuvs-bench-820-26.02a-cuda13-py3.10-amd64 is a manifest list Error: Process completed with exit code 1. ``` ([build link](https://github.com/rapidsai/docker/actions/runs/19864919436/job/56926457521?pr=820#step:4:23)) Looks like in newer versions of `docker`, builds create manifest lists by default instead of single image builds: * NVIDIA/gpu-operator#1940 * NVIDIA/k8s-driver-manager#132 * docker/build-push-action#1339 (comment) This opts out of that using the configuration option added in docker/build-push-action#1343 It also updates all `pre-commit` hooks, to avoid needing another CI run for #820 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #821
fixes #1339
We should not set provenance attestation if
BUILDX_NO_DEFAULT_ATTESTATIONSenv var is set.