Avoid NPE in OAuth updateAccessToken()#57
Merged
mmallis87 merged 5 commits intodocusign:masterfrom Feb 6, 2018
psytester:patch-1
Merged
Avoid NPE in OAuth updateAccessToken()#57mmallis87 merged 5 commits intodocusign:masterfrom psytester:patch-1
mmallis87 merged 5 commits intodocusign:masterfrom
psytester:patch-1
Conversation
Avoid NullPointerException in case accessTokenResponse does *not* contain "access_token" or "expires_in". For sure this should never happen, but it's part of negativ test while API integration and makes it more robust. The additional check was copied from ApiClient.configureJWTAuthorizationFlow()
Contributor
Author
|
My last commit 3f8db33 is the final one with single check per object. I hope it satisfy your coding styles. |
Contributor
|
@psytester thank you for submitting this PR! |
mmallis87
added a commit
that referenced
this pull request
Aug 29, 2019
Avoid NPE in OAuth updateAccessToken()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid NullPointerException in case accessTokenResponse does not contain "access_token" or "expires_in".
For sure this should never happen, but it's part of negativ test while API integration and makes it more robust.
The additional check was copied from ApiClient.configureJWTAuthorizationFlow()