QF1012: support implicit address-taking

Co-authored-by: Alan Donovan <[email protected]>
Closes: gh-1097

Author: dominikh

quickfix/qf1012/qf1012.go

@@ -3,6 +3,7 @@ package qf1012
 import (
 	"fmt"
 	"go/ast"
+	"go/token"
 	"go/types"
 	"strings"
 
@@ -57,9 +58,25 @@ var (
 
 func run(pass *analysis.Pass) (any, error) {
 	fn := func(node ast.Node) {
-		if m, ok := code.Match(pass, checkWriteBytesSprintfQ, node); ok {
+		getRecv := func(m *pattern.Matcher) (ast.Expr, types.Type) {
 			recv := m.State["recv"].(ast.Expr)
 			recvT := pass.TypesInfo.TypeOf(recv)
+
+			// Use *N, not N, for the interface check if N
+			// is a named non-interface type, since the pointer
+			// has a larger method set (https://staticcheck.dev/issues/1097).
+			// We assume the receiver expression is addressable
+			// since otherwise thre code wouldn't compile.
+			if _, ok := types.Unalias(recvT).(*types.Named); ok && !types.IsInterface(recvT) {
+				recvT = types.NewPointer(recvT)
+				recv = &ast.UnaryExpr{Op: token.AND, X: recv}
+
+			}
+			return recv, recvT
+		}
+
+		if m, ok := code.Match(pass, checkWriteBytesSprintfQ, node); ok {
+			recv, recvT := getRecv(m)
 			if !types.Implements(recvT, knowledge.Interfaces["io.Writer"]) {
 				return
 			}
@@ -78,8 +95,7 @@ func run(pass *analysis.Pass) (any, error) {
 			}))
 			report.Report(pass, node, msg, report.Fixes(fix))
 		} else if m, ok := code.Match(pass, checkWriteStringSprintfQ, node); ok {
-			recv := m.State["recv"].(ast.Expr)
-			recvT := pass.TypesInfo.TypeOf(recv)
+			recv, recvT := getRecv(m)
 			if !types.Implements(recvT, knowledge.Interfaces["io.StringWriter"]) {
 				return
 			}

quickfix/qf1012/testdata/go1.0/CheckWriteBytesSprintf/CheckWriteBytesSprintf.go

@@ -34,3 +34,8 @@ func fn2() {
 	sw.WriteString(fmt.Sprintf("%T", 0))
 	sw.WriteString(fmt.Sprintln("abc", "de"))
 }
+
+func fn3() {
+	var buf bytes.Buffer
+	buf.WriteString(fmt.Sprint("abc", "de")) //@ diag(`Use fmt.Fprint`)
+}

quickfix/qf1012/testdata/go1.0/CheckWriteBytesSprintf/CheckWriteBytesSprintf.go.golden

@@ -34,3 +34,8 @@ func fn2() {
 	sw.WriteString(fmt.Sprintf("%T", 0))
 	sw.WriteString(fmt.Sprintln("abc", "de"))
 }
+
+func fn3() {
+	var buf bytes.Buffer
+	fmt.Fprint(&buf, "abc", "de") //@ diag(`Use fmt.Fprint`)
+}