Skip to content

Commit 17f1ff9

Browse files
committed
[build] Don't set $(ImplicitlyExpandDesignTimeFacades)=False
Supporting both OS X and Linux is "interesting", for not fully understood reasons. On the one hand, the OS X `src/Mono.Posix` build was failing because there were *too many* references to `System.Runtime` (9a50c66): CSC: error CS1703: An assembly `System.Runtime' with the same identity has already been imported. Consider removing one of the references. Meanwhile, after commit 9a50c66 @atsushieno is unable to build `src/Mono.Posix` on Linux: error CS0012: The type `System.IDisposable' is defined in an assembly that is not referenced. Consider adding a reference to assembly `System.Runtime, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' The current hypothesis is that setting `$(ImplicitlyExpandDesignTimeFacades)` to False [0] is responsible for this, and the fix is to: 1. Don't Do That™: don't override `$(ImplicitlyExpandDesignTimeFacades)`. 2. Remove the explicit reference to `System.Runtime` in those projects. Let's see if that works. [0]: Related question: *why* was `$(ImplicitlyExpandDesignTimeFacades)` overridden in the first place? It was overridden so that we'd use the Xamarin.Android copy of `System.Runtime.dll` instead of the "system" one. However, this shouldn't be necessary, as we're not providing a custom PCL profile, so the normal `System.Runtime.dll` is fine.
1 parent 474dc74 commit 17f1ff9

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

src/Mono.Android.Export/Mono.Android.Export.csproj

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@
5252
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
5353
<Private>False</Private>
5454
</Reference>
55-
<Reference Include="System.Runtime">
56-
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
57-
<Private>False</Private>
58-
</Reference>
5955
</ItemGroup>
6056
<ItemGroup>
6157
<Compile Include="Properties\AssemblyInfo.cs" />
@@ -110,9 +106,6 @@
110106
<Compile Include="Mono.CodeGeneration\Exp.cs" />
111107
</ItemGroup>
112108
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
113-
<PropertyGroup>
114-
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
115-
</PropertyGroup>
116109
<ItemGroup>
117110
<ProjectReference Include="..\Mono.Android\Mono.Android.csproj">
118111
<Project>{66CF299A-CE95-4131-BCD8-DB66E30C4BF7}</Project>

src/Mono.Android/Mono.Android.csproj

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@
6363
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
6464
<Private>False</Private>
6565
</Reference>
66-
<Reference Include="System.Runtime">
67-
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
68-
<Private>False</Private>
69-
</Reference>
7066
</ItemGroup>
7167
<ItemGroup>
7268
<Compile Include="Android\IncludeAndroidResourcesFromAttribute.cs" />
@@ -302,9 +298,6 @@
302298
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
303299
<Import Project="Mono.Android.targets" />
304300
<Import Project="$(IntermediateOutputPath)android-$(AndroidApiLevel)\Mono.Android.projitems" Condition="Exists('$(IntermediateOutputPath)android-$(AndroidApiLevel)\Mono.Android.projitems')" />
305-
<PropertyGroup>
306-
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
307-
</PropertyGroup>
308301
<ItemGroup>
309302
<ProjectReference Include="..\..\build-tools\api-merge\api-merge.csproj">
310303
<Project>{3FC3E78B-F7D4-42EA-BBE8-4535DF42BFF8}</Project>

src/Xamarin.Android.NUnitLite/Xamarin.Android.NUnitLite.csproj

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@
5858
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
5959
<Private>False</Private>
6060
</Reference>
61-
<Reference Include="System.Runtime">
62-
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
63-
<Private>False</Private>
64-
</Reference>
6561
</ItemGroup>
6662
<ItemGroup>
6763
<Compile Include="Resources\Resource.designer.cs" />
@@ -348,9 +344,6 @@
348344
<AndroidResource Include="Resources\layout\test_suite.axml" />
349345
</ItemGroup>
350346
<Import Project="$(OutputPath)\..\..\..\xbuild\Xamarin\Android\Xamarin.Android.CSharp.targets" />
351-
<PropertyGroup>
352-
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
353-
</PropertyGroup>
354347
<ItemGroup>
355348
<ProjectReference Include="..\Mono.Android\Mono.Android.csproj">
356349
<Project>{66CF299A-CE95-4131-BCD8-DB66E30C4BF7}</Project>

0 commit comments

Comments
 (0)