Commit 17f1ff9
committed
[build] Don't set
Supporting both OS X and Linux is "interesting", for not fully
understood reasons.
On the one hand, the OS X `src/Mono.Posix` build was failing because
there were *too many* references to `System.Runtime` (9a50c66):
CSC: error CS1703: An assembly `System.Runtime' with the same identity
has already been imported. Consider removing one of the references.
Meanwhile, after commit 9a50c66 @atsushieno is unable to build
`src/Mono.Posix` on Linux:
error CS0012: The type `System.IDisposable' is defined in an assembly
that is not referenced. Consider adding a reference to assembly
`System.Runtime, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
The current hypothesis is that setting
`$(ImplicitlyExpandDesignTimeFacades)` to False [0] is responsible for
this, and the fix is to:
1. Don't Do That™: don't override
`$(ImplicitlyExpandDesignTimeFacades)`.
2. Remove the explicit reference to `System.Runtime` in those
projects.
Let's see if that works.
[0]: Related question: *why* was
`$(ImplicitlyExpandDesignTimeFacades)` overridden in the first
place? It was overridden so that we'd use the Xamarin.Android
copy of `System.Runtime.dll` instead of the "system" one.
However, this shouldn't be necessary, as we're not providing a
custom PCL profile, so the normal `System.Runtime.dll` is fine.$(ImplicitlyExpandDesignTimeFacades)=False1 parent 474dc74 commit 17f1ff9
File tree
3 files changed
+0
-21
lines changed- src
- Mono.Android.Export
- Mono.Android
- Xamarin.Android.NUnitLite
3 files changed
+0
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 55 | | |
60 | 56 | | |
61 | 57 | | |
| |||
110 | 106 | | |
111 | 107 | | |
112 | 108 | | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | 109 | | |
117 | 110 | | |
118 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 66 | | |
71 | 67 | | |
72 | 68 | | |
| |||
302 | 298 | | |
303 | 299 | | |
304 | 300 | | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | 301 | | |
309 | 302 | | |
310 | 303 | | |
| |||
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | 61 | | |
66 | 62 | | |
67 | 63 | | |
| |||
348 | 344 | | |
349 | 345 | | |
350 | 346 | | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | 347 | | |
355 | 348 | | |
356 | 349 | | |
| |||
0 commit comments