Skip to content

Commit d58db81

Browse files
committed
Port test fix.
1 parent 70f7ce7 commit d58db81

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

tests/MSBuildDeviceIntegration/Tests/DebuggingTest.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ public void ClearDebugProperties ()
2525
ClearDebugProperty ();
2626
}
2727

28-
void SetTargetFrameworkAndManifest(XamarinAndroidApplicationProject proj, Builder builder)
28+
void SetTargetFrameworkAndManifest(XamarinAndroidApplicationProject proj, Builder builder, int? apiLevelOverride)
2929
{
3030
builder.LatestTargetFrameworkVersion (out string apiLevel);
3131
proj.SupportedOSPlatformVersion = "24";
3232
proj.AndroidManifest = $@"<?xml version=""1.0"" encoding=""utf-8""?>
3333
<manifest xmlns:android=""http://schemas.android.com/apk/res/android"" android:versionCode=""1"" android:versionName=""1.0"" package=""{proj.PackageName}"">
34-
<uses-sdk android:targetSdkVersion=""{apiLevel}"" />
34+
<uses-sdk android:targetSdkVersion=""{apiLevelOverride?.ToString () ?? apiLevel}"" />
3535
<application android:label=""${{PROJECT_NAME}}"">
3636
</application >
3737
</manifest>";
@@ -67,7 +67,7 @@ public void ApplicationRunsWithoutDebugger ([Values (false, true)] bool isReleas
6767
useEmbeddedDex = false;
6868
}
6969
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
70-
SetTargetFrameworkAndManifest (proj, b);
70+
SetTargetFrameworkAndManifest (proj, b, null);
7171
proj.AndroidManifest = proj.AndroidManifest.Replace ("<application ", $"<application android:extractNativeLibs=\"{extractNativeLibs.ToString ().ToLowerInvariant ()}\" android:useEmbeddedDex=\"{useEmbeddedDex.ToString ().ToLowerInvariant ()}\" ");
7272
Assert.True (b.Install (proj), "Project should have installed.");
7373
var manifest = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "android", "AndroidManifest.xml");
@@ -124,7 +124,7 @@ public void ClassLibraryMainLauncherRuns ([Values (true, false)] bool preloadAss
124124

125125
using (var libBuilder = CreateDllBuilder (Path.Combine (path, lib.ProjectName)))
126126
using (var appBuilder = CreateApkBuilder (Path.Combine (path, app.ProjectName))) {
127-
SetTargetFrameworkAndManifest (app, appBuilder);
127+
SetTargetFrameworkAndManifest (app, appBuilder, null);
128128
Assert.IsTrue (libBuilder.Build (lib), "library build should have succeeded.");
129129
Assert.True (appBuilder.Install (app), "app should have installed.");
130130
RunProjectAndAssert (app, appBuilder);
@@ -220,7 +220,7 @@ public override void OnCreate ()
220220
"),
221221
});
222222
using (var b = CreateApkBuilder (path)) {
223-
SetTargetFrameworkAndManifest (proj, b);
223+
SetTargetFrameworkAndManifest (proj, b, null);
224224
Assert.True (b.Install (proj), "Project should have installed.");
225225

226226
int breakcountHitCount = 0;
@@ -430,6 +430,7 @@ public Foo ()
430430
lib.TargetFramework = "net7.0-android";
431431
app.TargetFramework = "net7.0-android";
432432
}
433+
433434
app.SetProperty ("AndroidPackageFormat", packageFormat);
434435
app.MainPage = app.MainPage.Replace ("InitializeComponent ();", "InitializeComponent (); new Foo ();");
435436
app.AddReference (lib);
@@ -440,7 +441,7 @@ public Foo ()
440441
using (var appBuilder = CreateApkBuilder (Path.Combine (path, app.ProjectName))) {
441442
Assert.True (libBuilder.Build (lib), "Library should have built.");
442443

443-
SetTargetFrameworkAndManifest (app, appBuilder);
444+
SetTargetFrameworkAndManifest (app, appBuilder, app.TargetFramework == "net7.0-android" ? 33 : null);
444445
Assert.True (appBuilder.Install (app, parameters: parameters.ToArray ()), "App should have installed.");
445446

446447
if (!embedAssemblies) {

0 commit comments

Comments
 (0)