[Automated] Update API Surface Area#13639
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
github-actions
bot
added
the
NO-MERGE
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13639Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13639" |
github-actions
bot
force-pushed
the
update-api-diffs
branch
4 times, most recently
from
0589f59 to
d989774
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
3 times, most recently
from
5fb9cc5 to
b9f470c
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
7 times, most recently
from
7abc0bf to
4cf58f2
Compare
github-actions
bot
requested review from
captainsafia and
eerhardt
as code owners
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
4cf58f2 to
acbc422
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
5 times, most recently
from
c21ccf7 to
b5a7cf3
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
5 times, most recently
from
9d206f3 to
c00d18e
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
7 times, most recently
from
3d2fd2d to
4c9c6e3
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
6 times, most recently
from
fc66e16 to
18a2ea1
Compare
eerhardt
reviewed
Mar 18, 2026
| protected override void DefineProvisionableProperties() { } | ||
| } | ||
|
|
||
| public partial class StaticValueProvider<T> : ApplicationModel.IValueProvider, ApplicationModel.IManifestExpressionProvider |
Member
There was a problem hiding this comment.
cc @ericsuh
StaticValueProvider<T> implements IValueProvider and IManifestExpressionProvider. This looks like infrastructure plumbing — it's used by AzureHostedAgentResource.Version and AzurePromptAgentResource.Version. Does it need to be public, or could it be internal with the Version properties using a different public type?
Member
There was a problem hiding this comment.
@ericsuh - it looks like this is only used for "Version" outputs. Can this just be a BicepOutputReference?
| @@ -0,0 +1,28 @@ | |||
| //------------------------------------------------------------------------------ | |||
Member
There was a problem hiding this comment.
ℹ️ [Preview Package] The 5 new Aspire.Hosting.CodeGeneration.* packages (Go, Java, Python, Rust, TypeScript) are shipping as stable — they don't have SuppressFinalPackageVersion=true in their .csproj files.
Brand new packages typically ship as preview until they've had sufficient bake time. Is shipping these as stable intentional?
src/Components/Aspire.MongoDB.EntityFrameworkCore/api/Aspire.MongoDB.EntityFrameworkCore.cs
Show resolved
Hide resolved
Member
API Review Summary3 errors, 6 warnings, 3 info across 57 changed API files. ❌ Errors (3)
|
eerhardt
previously requested changes
Mar 18, 2026
src/Aspire.Hosting.CodeGeneration.Go/api/Aspire.Hosting.CodeGeneration.Go.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.AppConfiguration/api/Aspire.Hosting.Azure.AppConfiguration.cs
Show resolved
Hide resolved
eerhardt
reviewed
Mar 18, 2026
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
API review update — 1 new finding for the newly added Aspire.TypeSystem package. Previous 12 findings on other files remain valid.
16 tasks
Contributor
Author
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
Author
|
🎬 CLI E2E Test Recordings — 49 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23501538834 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.