Add polyglot exports for Aspire.Hosting.Orleans by sebastienros · Pull Request #14891 · microsoft/aspire

sebastienros · 2026-03-03T18:07:50Z

Description

Add polyglot AspireExport coverage for Aspire.Hosting.Orleans.
Related to #14069.

Validation:

dotnet build src/Aspire.Hosting.Orleans/Aspire.Hosting.Orleans.csproj -v minimal
(cd playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost && npx tsc --noEmit)

Fixes # (issue)

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

github-actions · 2026-03-03T18:07:59Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14891

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14891"

Copilot

Pull request overview

Adds ATS/polyglot export coverage for Aspire.Hosting.Orleans so TypeScript AppHosts can configure Orleans resources via generated capabilities, and includes a TypeScript ValidationAppHost to compile-check the generated SDK surface.

Changes:

Annotates Orleans resource types and extension methods with [AspireExport] and marks non-polyglot-friendly overloads with [AspireExportIgnore].
Adds Orleans TypeScript ValidationAppHost (tsconfig/package manifests, generated .modules, and sample apphost.ts) to validate codegen/typing.
Exposes Orleans “silo” and “client” reference wiring as separate polyglot capabilities.

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Aspire.Hosting.Orleans/OrleansServiceExtensions.cs	Adds `[AspireExport]` coverage for Orleans configuration APIs and reference wiring; adds ignore annotations for non-polyglot overloads.
src/Aspire.Hosting.Orleans/OrleansServiceClientExtensions.cs	Exports the Orleans client reference wiring capability for polyglot AppHosts.
src/Aspire.Hosting.Orleans/OrleansServiceClient.cs	Marks Orleans client type as an ATS-exported type.
src/Aspire.Hosting.Orleans/OrleansService.cs	Marks Orleans service type as an ATS-exported type.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/tsconfig.json	TypeScript compiler configuration for Orleans ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/package.json	NPM manifest for the Orleans ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/package-lock.json	Dependency lockfile for Orleans ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/apphost.ts	TypeScript AppHost script exercising the exported Orleans capabilities.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/apphost.run.json	Run profile/environment variables for the Orleans ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.modules/transport.ts	Generated ATS transport/runtime support for the ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.modules/base.ts	Generated base types/helpers for the ValidationAppHost.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.modules/.codegen-hash	Tracks codegen hash for generated `.modules` output.
playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.aspire/settings.json	Configures the ValidationAppHost as a TypeScript AppHost and references the Orleans package.

Files not reviewed (1)

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/package-lock.json: Language not supported

src/Aspire.Hosting.Orleans/OrleansServiceClientExtensions.cs

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/apphost.ts

src/Aspire.Hosting.Orleans/OrleansServiceExtensions.cs

github-actions · 2026-03-03T19:08:32Z

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit f47772f:

Test	Recording
AddPackageInteractiveWhileAppHostRunningDetached	▶️ View Recording
AddPackageWhileAppHostRunningDetached	▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect	▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig	▶️ View Recording
AgentInitCommand_WithMalformedMcpJson_ShowsErrorAndExitsNonZero	▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps	▶️ View Recording
Banner_DisplayedOnFirstRun	▶️ View Recording
Banner_DisplayedWithExplicitFlag	▶️ View Recording
CreateAndDeployToDockerCompose	▶️ View Recording
CreateAndDeployToDockerComposeInteractive	▶️ View Recording
CreateAndPublishToKubernetes	▶️ View Recording
CreateAndRunAspireStarterProject	▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle	▶️ View Recording
CreateAndRunJsReactProject	▶️ View Recording
CreateAndRunPythonReactProject	▶️ View Recording
CreateAndRunTypeScriptStarterProject	▶️ View Recording
CreateEmptyAppHostProject	▶️ View Recording
CreateStartAndStopAspireProject	▶️ View Recording
CreateStartWaitAndStopAspireProject	▶️ View Recording
CreateTypeScriptAppHostWithViteApp	▶️ View Recording
DescribeCommandResolvesReplicaNames	▶️ View Recording
DescribeCommandShowsRunningResources	▶️ View Recording
DetachFormatJsonProducesValidJson	▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig	▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted	▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	▶️ View Recording
LogsCommandShowsResourceLogs	▶️ View Recording
PsCommandListsRunningAppHost	▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout	▶️ View Recording
SecretCrudOnDotNetAppHost	▶️ View Recording
SecretCrudOnTypeScriptAppHost	▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	▶️ View Recording
StopAllAppHostsFromAppHostDirectory	▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory	▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError	▶️ View Recording
StopNonInteractiveSingleAppHost	▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully	▶️ View Recording
TypeScriptAppHostWithProjectReferenceIntegration	▶️ View Recording

_{📹 Recordings uploaded automatically from CI run #22697464622}

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/apphost.ts

src/Aspire.Hosting.Orleans/OrleansServiceClient.cs

changes mde

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.aspire/settings.json

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Rename withSiloReference → withOrleansReference and withClientReference → withOrleansClientReference to follow the pattern used by other integrations (e.g., withServiceReference for IResourceWithServiceDiscovery). Update playground ValidationAppHost and regenerate TypeScript SDK. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Removed sdkVersion and cleared Aspire.Hosting.Orleans version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add AspireExport coverage for Orleans Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update src/Aspire.Hosting.Orleans/OrleansServiceExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Aspire.Hosting.Orleans/OrleansServiceClientExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix XML documentation return tags in OrleansServiceExtensions * Address review feedback for polyglot-orleans Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Rename Orleans WithReference export IDs to match naming conventions Rename withSiloReference → withOrleansReference and withClientReference → withOrleansClientReference to follow the pattern used by other integrations (e.g., withServiceReference for IResourceWithServiceDiscovery). Update playground ValidationAppHost and regenerate TypeScript SDK. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Cleanup settings.json Removed sdkVersion and cleared Aspire.Hosting.Orleans version. * Regenerate Orleans playground after rebase on release/13.2 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 18:07

Copilot started reviewing on behalf of sebastienros March 3, 2026 18:09 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 3, 2026

[pull requests] Review required #13834

Open

sebastienros mentioned this pull request Mar 3, 2026

Epic: TypeScript AppHost - Complete Integration Support #14069

Closed

76 tasks

sebastienros requested review from IEvangelist and davidfowl March 3, 2026 19:21

IEvangelist previously requested changes Mar 3, 2026

View reviewed changes

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/apphost.ts Outdated Show resolved Hide resolved

src/Aspire.Hosting.Orleans/OrleansServiceClient.cs Show resolved Hide resolved

dotnet-policy-service bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 3, 2026

davidfowl previously approved these changes Mar 4, 2026

View reviewed changes

davidfowl reviewed Mar 4, 2026

View reviewed changes

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.aspire/settings.json Outdated Show resolved Hide resolved

davidfowl reviewed Mar 4, 2026

View reviewed changes

playground/polyglot/TypeScript/Aspire.Hosting.Orleans/ValidationAppHost/.aspire/settings.json Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 4, 2026

[13.2-burndown] Daily Burndown Report - March 4, 2026 #14940

Closed

sebastienros requested a review from davidfowl March 5, 2026 00:51

davidfowl approved these changes Mar 5, 2026

View reviewed changes

sebastienros and others added 8 commits March 4, 2026 17:09

Add AspireExport coverage for Orleans

93d4ffd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update src/Aspire.Hosting.Orleans/OrleansServiceExtensions.cs

b608df0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Aspire.Hosting.Orleans/OrleansServiceClientExtensions.cs

ed51d90

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix XML documentation return tags in OrleansServiceExtensions

645bb7d

Address review feedback for polyglot-orleans

a275e03

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Cleanup settings.json

b4f4d92

Removed sdkVersion and cleared Aspire.Hosting.Orleans version.

Regenerate Orleans playground after rebase on release/13.2

f47772f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros force-pushed the sebros/polyglot-orleans branch from f6e70b9 to f47772f Compare March 5, 2026 01:11

sebastienros merged commit 09f3dcf into release/13.2 Mar 5, 2026
385 checks passed

sebastienros deleted the sebros/polyglot-orleans branch March 5, 2026 03:16

dotnet-policy-service bot added this to the 13.2 milestone Mar 5, 2026

github-actions bot mentioned this pull request Mar 5, 2026

[13.2-burndown] Daily Burndown Report - March 5, 2026 #14972

Closed

github-actions bot locked and limited conversation to collaborators Apr 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add polyglot exports for Aspire.Hosting.Orleans#14891

Add polyglot exports for Aspire.Hosting.Orleans#14891
sebastienros merged 8 commits intorelease/13.2from
sebros/polyglot-orleans

sebastienros commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sebastienros commented Mar 3, 2026

Description

Checklist

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎬 CLI E2E Test Recordings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading