Refine polyglot exports for Aspire.Hosting.Azure.Sql#15011
Merged
davidfowl merged 2 commits intorelease/13.2from Mar 7, 2026
Merged
Refine polyglot exports for Aspire.Hosting.Azure.Sql#15011davidfowl merged 2 commits intorelease/13.2from
davidfowl merged 2 commits intorelease/13.2from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15011Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15011" |
Contributor
There was a problem hiding this comment.
Pull request overview
Refines polyglot export surface for Aspire.Hosting.Azure.Sql by annotating resources/members for export/ignore, and updates the TypeScript ValidationAppHost to align with the repo validation pattern and regenerated assets.
Changes:
- Added
AspireExport(ExposeProperties = true)andAspireExportIgnoreannotations to Azure SQL resource types/members. - Updated Azure SQL extension method export/ignore metadata for polyglot consumption.
- Normalized the TypeScript ValidationAppHost and updated its
.aspirepackage settings to include Azure Storage.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Exposes server resource properties for polyglot while explicitly excluding non-polyglot members. |
| src/Aspire.Hosting.Azure.Sql/AzureSqlExtensions.cs | Ignores subnet API for polyglot and exports the admin deployment script storage configuration API. |
| src/Aspire.Hosting.Azure.Sql/AzureSqlDatabaseResource.cs | Exposes database resource properties for polyglot while excluding non-polyglot members. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/apphost.ts | Expands TypeScript coverage to validate exported APIs and properties in a standardized pattern. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/.aspire/settings.json | Adds Azure Storage package dependency to support ValidationAppHost usage. |
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/apphost.ts
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Sql/ValidationAppHost/apphost.ts
Show resolved
Hide resolved
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22775173678 |
davidfowl
reviewed
Mar 7, 2026
| /// peSubnet.AddPrivateEndpoint(sql); | ||
| /// </code> | ||
| /// </example> | ||
| [AspireExportIgnore(Reason = "Azure subnet resources are not currently available to polyglot app hosts.")] |
davidfowl
approved these changes
Mar 7, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add Azure SQL polyglot export coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Normalize Azure SQL validation apphost Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radical
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add Azure SQL polyglot export coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Normalize Azure SQL validation apphost Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description