Update the diagnotic ids of the AspireExportAnalyzer.#15102
Merged
eerhardt merged 2 commits intomicrosoft:release/13.2from Mar 10, 2026
Merged
Update the diagnotic ids of the AspireExportAnalyzer.#15102eerhardt merged 2 commits intomicrosoft:release/13.2from
eerhardt merged 2 commits intomicrosoft:release/13.2from
Conversation
The current IDs conflict with existing diagnostic IDs that we've already shipped.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15102Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15102" |
Contributor
There was a problem hiding this comment.
Pull request overview
Renames AspireExportAnalyzer diagnostic IDs to avoid collisions with already-shipped Aspire diagnostics (notably ASPIRE007/ASPIRE008), and updates analyzer tests/release tracking to match the new IDs.
Changes:
- Updated
AspireExportAnalyzerdiagnostic IDs fromASPIRE00xtoASPIREEXPORT00x. - Updated analyzer unit tests and release tracking to use the new diagnostic IDs.
- Updated an MSBuild integration test expectation (currently incorrect; see comment).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/MSBuildTests.cs | Updates expected build error ID (but currently mismatches the MSBuild target diagnostic). |
| tests/Aspire.Hosting.Analyzers.Tests/AspireExportAnalyzerTests.cs | Renames test method names to reflect new analyzer diagnostic IDs. |
| src/Aspire.Hosting.Analyzers/AspireExportAnalyzer.cs | Updates inline comments referencing diagnostic IDs. |
| src/Aspire.Hosting.Analyzers/AspireExportAnalyzer.Diagnostics.cs | Renames analyzer DiagnosticDescriptor IDs to ASPIREEXPORT###. |
| src/Aspire.Hosting.Analyzers/AnalyzerReleases.Unshipped.md | Updates unshipped analyzer rule IDs and documentation links. |
sebastienros
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current IDs conflict with existing diagnostic IDs that we've already shipped.
See https://aspire.dev/diagnostics/aspire007 and https://aspire.dev/diagnostics/aspire008