Skip to content

[tests] Add manifest timestamp checks to WindowsTest.#25093

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/BundleStructureWithRemoteMac-failure
Apr 7, 2026
Merged

[tests] Add manifest timestamp checks to WindowsTest.#25093
rolfbjarne merged 1 commit intomainfrom
dev/rolf/BundleStructureWithRemoteMac-failure

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

There are random test failures in this test:

Remote .NET tests/Xamarin.Tests.WindowsTest.BundleStructureWithRemoteMac(iOS,"ios-arm64",All,"Debug"): Failed: The target '_CompileAppManifest' was unexpectedly executed (_CompileAppManifest Rebuild 1)

Add more asserts to this test to try to track down what's happening.

There are random test failures in this test:

> Remote .NET tests/Xamarin.Tests.WindowsTest.BundleStructureWithRemoteMac(iOS,"ios-arm64",All,"Debug"): Failed: The target '_CompileAppManifest' was unexpectedly executed (_CompileAppManifest Rebuild 1)

Add more asserts to this test to try to track down what's happening.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional assertions to the Windows remote build BundleStructureWithRemoteMac test to help diagnose sporadic _CompileAppManifest incrementality failures by tracking manifest-related file state across rebuilds.

Changes:

  • Introduce helpers to snapshot a file’s last-write timestamp (UTC) and contents, and assert they remain unchanged.
  • Capture initial state for AppManifest.plist, _CompileAppManifest.inputs, and shared-dotnet.plist, with a couple of sanity checks on initial build.
  • Assert those files remain unchanged across three subsequent rebuilds (after touching code, deleting bin, and a no-op rebuild).

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #4867e79] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4867e79bece279d788cbd608d024f194c06c8357 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #4867e79] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4867e79bece279d788cbd608d024f194c06c8357 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4867e79bece279d788cbd608d024f194c06c8357 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #4867e79] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4867e79bece279d788cbd608d024f194c06c8357 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne marked this pull request as ready for review April 6, 2026 13:24
@rolfbjarne rolfbjarne enabled auto-merge (squash) April 6, 2026 13:24
@vs-mobiletools-engineering-service2

This comment has been minimized.

1 similar comment
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

1 similar comment
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #4867e79] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. [attempt 7] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 4867e79bece279d788cbd608d024f194c06c8357 [PR build]

@rolfbjarne rolfbjarne merged commit 0b8b50e into main Apr 7, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants