Commit 38ac72f
Add Pin.ShowInfoWindow() and Pin.HideInfoWindow() methods (#33985)
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!
## Description
Adds the ability to programmatically show and hide map pin info
windows/callouts, addressing a long-standing community request.
Fixes #10601
### API Changes
**`Microsoft.Maui.Maps.IMap`** (Core):
- `void ShowInfoWindow(IMapPin pin)` — Shows the info window for the
specified pin
- `void HideInfoWindow(IMapPin pin)` — Hides the info window for the
specified pin
**`Microsoft.Maui.Controls.Maps.Pin`** (Controls):
- `void ShowInfoWindow()` — Shows the info window for this pin
- `void HideInfoWindow()` — Hides the info window for this pin
### Implementation Details
- **Android**: Uses `Marker.ShowInfoWindow()` /
`Marker.HideInfoWindow()` via Google Maps SDK
- **iOS/MacCatalyst**: Uses `MKMapView.SelectAnnotation()` /
`MKMapView.DeselectAnnotation()` via MapKit
- **Windows/Tizen/Standard**: Stub implementations (not supported)
### Bug Fix: Pin.Parent tracking
Fixed a pre-existing bug where `Pin.Parent` was never set when pins were
added to `Map.Pins`. The `PinsOnCollectionChanged` method now properly
sets `pin.Parent = this` for new pins and `pin.Parent = null` for
removed pins. This fix is required for `ShowInfoWindow()` to work (it
needs to traverse to the parent Map to invoke the handler), but also
fixes any other code path that relies on `Pin.Parent`.
### Testing
- 4 unit tests added (ShowInfoWindow, HideInfoWindow,
ShowInfoWindowRequiresParent, HideInfoWindowRequiresParent)
- All 33 map unit tests pass
- Manually verified on iOS, Android, and MacCatalyst
Part of Maps Epic: #33787
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent c0073ff commit 38ac72f
28 files changed
Lines changed: 314 additions & 0 deletions
File tree
- src
- Controls
- Maps/src
- HandlerImpl
- PublicAPI
- net-android
- net-ios
- net-maccatalyst
- net-tizen
- net-windows
- netstandard
- net
- samples/Controls.Sample/Pages/Controls/MapsGalleries
- tests/Core.UnitTests
- Core/maps/src
- Core
- Handlers/Map
- PublicAPI
- net-android
- net-ios
- net-maccatalyst
- net-tizen
- net-windows
- netstandard
- net
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
288 | 304 | | |
289 | 305 | | |
290 | 306 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
215 | 239 | | |
216 | 240 | | |
217 | 241 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
0 commit comments