Skip to content

Fix crash when TimePicker.Time is set to null#32660

Merged
jfversluis merged 1 commit intodotnet:inflight/currentfrom
breyed:patch-1
Nov 18, 2025
Merged

Fix crash when TimePicker.Time is set to null#32660
jfversluis merged 1 commit intodotnet:inflight/currentfrom
breyed:patch-1

Conversation

@breyed
Copy link
Copy Markdown
Contributor

@breyed breyed commented Nov 17, 2025 •
edited by PureWeen
Loading

Description of Change

Since TimePicker now supports nullable, the casts need to be nullable to match the TimeChangedEventArgs properties.

Issues Fixed

timeSpan.Time = null throws a NullReferenceException. (This PR is also the reporting issue.)

#32709

Copilot AI review requested due to automatic review settings November 17, 2025 00:24
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 17, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Nov 17, 2025

Hey there @@breyed! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot AI reviewed Nov 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a crash that occurs when setting TimePicker.Time to null by updating the type casts to nullable TimeSpan in the TimePropertyChanged event handler.

Key Changes:

  • Modified the casts in TimePropertyChanged from (TimeSpan) to (TimeSpan?) to properly handle nullable TimeSpan values

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Nov 18, 2025 •
edited
Loading

/azp run MAUI-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Nov 18, 2025

/rebase

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Nov 18, 2025

Awesome @breyed sorry we missed this! Thank you for contributing!

@jfversluis jfversluis changed the base branch from main to inflight/current November 18, 2025 15:45
@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Nov 18, 2025

/rebase

@breyed @jfversluis
Change TimeSelected event to handle nullable TimeSpan
75d9dd5 
Since TimePicker now supports nullable, the casts need to be nullable to match the TimeChangedEventArgs properties. Otherwise, `timeSpan.Time = null` throws a NullReferenceException.
@jfversluis jfversluis merged commit 55ec5ec into dotnet:inflight/current Nov 18, 2025
1 check passed
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Nov 18, 2025

/backport to release/10.0.1xx-sr1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2025

Started backporting to release/10.0.1xx-sr1 (link to workflow run)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2025

@PureWeen backporting to release/10.0.1xx-sr1 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output 
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

Copilot AI mentioned this pull request Nov 18, 2025
Merged
Copilot AI added a commit that referenced this pull request Nov 18, 2025
@PureWeen
Fix crash when TimePicker.Time is set to null (backport from PR #32660)
c3d0cb4 
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
@kubaflo kubaflo mentioned this pull request Nov 18, 2025
Closed
PureWeen added a commit that referenced this pull request Nov 19, 2025
@PureWeen
Fix crash when TimePicker.Time is set to null (backport from PR #32660)…
b5d476f 
… (#32715)

* Initial plan

* Fix crash when TimePicker.Time is set to null (backport from PR #32660)

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
@dependabot dependabot bot mentioned this pull request Nov 25, 2025
Closed
evgenygunko pushed a commit to evgenygunko/CopyWordsDA that referenced this pull request Nov 26, 2025
@evgenygunko
Merged PR 696: chore(deps): update Microsoft.Maui.Controls to 10.0.11
40bbf3f 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.10` -> `10.0.11` |

---

### Release Notes

<details>
<summary>dotnet/maui (Microsoft.Maui.Controls)</summary>

### [`v10.0.11`](https://github.com/dotnet/maui/releases/tag/10.0.11): SR1.1

[Compare Source](dotnet/maui@10.0.10...10.0.11)

##### What's Changed

.NET MAUI 10.0.11 introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 11 commits with various improvements, bug fixes, and enhancements.

##### .NET MAUI Product Fixes

##### Android

-   Fix content page title clipping on Android API < 30 with window insets compatibility by [@&#8203;Copilot](https://github.com/Copilot) in dotnet/maui#32738

    <details>
    <summary>🔧 Fixes</summary>

    -   [Shell content page title position incorrect/clipped](dotnet/maui#32526)

    </details>

##### Button

-   \[release/10.0.1xx-sr1] Removed Value property coercion in RadioButton by [@&#8203;github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32604

    <details>
    <summary>🔧 Fixes</summary>

    -   [Removed Value property coercion in RadioButton](dotnet/maui#32489)

    </details>

##### DateTimePicker

-   Fix crash when TimePicker.Time is set to null (backport from PR [#&#8203;32660](dotnet/maui#32660)) by [@&#8203;Copilot](https://github.com/Copilot) in dotnet/maui#32715

    <details>
    <summary>🔧 Fixes</summary>

    -   [Fix crash when TimePicker.Time is set to null](dotnet/maui#32660)

    </details>

##### Gestures

-   \[release/10.0.1xx-sr1] predictive back gesture support for Android 13+ by [@&#8203;github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32635

    <details>
    <summary>🔧 Fixes</summary>

    -   [predictive back gesture support for Android 13+](dotnet/maui#32461)

    </details>

##### Infrastructure

-   \[release/10.0.1xx-sr1] \[ci] Revert changes setting Creator by [@&#8203;github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32803

    <details>
    <summary>🔧 Fixes</summary>

    -   [\[ci\] Revert changes setting Creator](dotnet/maui#32743)

    </details>

##### Mediapicker

-   \[release/10.0.1xx-sr1] \[Android] Refactor selection limit handling in MediaPicker by [@&#8203;github-actions](https://github.com/github-actions)\[bot] in dotnet/maui#32628

    <details>
    <summary>🔧 Fixes</summary>

    -   [\[Android\] Refactor selection limit handling in MediaPicker](dotnet/maui#32571)

   ...
This was referenced Dec 1, 2025
Closed
Closed
This was referenced Dec 1, 2025
Closed
Merged
Closed
Merged
Closed
This was referenced Dec 18, 2025
Closed
Closed
Merged
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis jfversluis approved these changes

Assignees

No one assigned

Labels

community ✨ Community Contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@breyed @jfversluis @PureWeen