Skip to content

Commit 43bdb17

Browse files
CopilotEgorBo
andcommitted
Address review feedback: use emitDispCommentForHandle and remove test
Use emitDispCommentForHandle instead of directly calling eeGetMethodFullName and printf, matching the pattern used by movz/movk constant annotations. Remove the FileCheck test since it would only run in checked mode where the method name already appears on the movz/movk constant instructions. Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/84a22a2e-9c3e-40ef-ab3b-97113c002f92
1 parent 4c3d843 commit 43bdb17

3 files changed

Lines changed: 1 addition & 48 deletions

File tree

src/coreclr/jit/emitarm64.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13560,11 +13560,7 @@ void emitter::emitDispInsHelp(
1356013560
emitDispReg(id->idReg3(), EA_PTRSIZE, false);
1356113561
}
1356213562

13563-
if (id->idDebugOnlyInfo()->idMemCookie != 0)
13564-
{
13565-
methodName = m_compiler->eeGetMethodFullName((CORINFO_METHOD_HANDLE)id->idDebugOnlyInfo()->idMemCookie);
13566-
printf(" // %s", methodName);
13567-
}
13563+
emitDispCommentForHandle(0, id->idDebugOnlyInfo()->idMemCookie, GTF_ICON_FTN_ADDR);
1356813564
break;
1356913565

1357013566
case IF_LS_1A: // LS_1A XX...V..iiiiiiii iiiiiiiiiiittttt Rt PC imm(1MB)

src/tests/JIT/opt/Calls/IndirectCallAnnotation.cs

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/tests/JIT/opt/Calls/IndirectCallAnnotation.csproj

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)