Skip to content

Commit 5af27a5

Browse files
authored
Remove few more ILLink warnings in System.Data.Common (#55335)
1 parent e4e942f commit 5af27a5

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

src/libraries/System.Data.Common/src/ILLink/ILLink.Suppressions.xml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<linker>
33
<assembly fullname="System.Data.Common, PublicKeyToken=b03f5f7f11d50a3a">
4-
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
5-
<argument>ILLink</argument>
6-
<argument>IL2026</argument>
7-
<property name="Scope">member</property>
8-
<property name="Target">M:System.Data.ColumnTypeConverter.ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type)</property>
9-
</attribute>
10-
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
11-
<argument>ILLink</argument>
12-
<argument>IL2060</argument>
13-
<property name="Scope">member</property>
14-
<property name="Target">M:System.Data.DataRowExtensions.UnboxT`1.Create</property>
15-
</attribute>
164
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
175
<argument>ILLink</argument>
186
<argument>IL2026</argument>
@@ -61,12 +49,6 @@
6149
<property name="Scope">member</property>
6250
<property name="Target">M:System.Data.DataTable.WriteXmlCore(System.Xml.XmlWriter)</property>
6351
</attribute>
64-
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
65-
<argument>ILLink</argument>
66-
<argument>IL2026</argument>
67-
<property name="Scope">member</property>
68-
<property name="Target">M:System.Data.DataView.SetRowFilter(System.String)</property>
69-
</attribute>
7052
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
7153
<argument>ILLink</argument>
7254
<argument>IL2026</argument>

src/libraries/System.Data.Common/src/System/Data/ColumnTypeConverter.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
using System.ComponentModel;
55
using System.ComponentModel.Design.Serialization;
6+
using System.Diagnostics.CodeAnalysis;
67
using System.Globalization;
78
using System.Data.SqlTypes;
89
using System.Reflection;
@@ -65,6 +66,8 @@ public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destina
6566
/// <summary>
6667
/// Converts the given value object to the specified destination type.
6768
/// </summary>
69+
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
70+
Justification = "InstanceDescriptor calls GetType(string) on AssemblyQualifiedName of instance of type we already have in here.")]
6871
public override object? ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)
6972
{
7073
if (destinationType == null)

0 commit comments

Comments
 (0)