Enable CA1419 (SafeHandle public parameterless ctor) (#55460)

Author: stephentoub

eng/CodeAnalysis.ruleset

@@ -68,6 +68,7 @@
     <Rule Id="CA1416" Action="Warning" />       <!-- Validate platform compatibility -->
     <Rule Id="CA1417" Action="Warning" />       <!-- Do not use 'OutAttribute' on string parameters for P/Invokes -->
     <Rule Id="CA1418" Action="Warning" />       <!-- Use valid platform string -->
+    <Rule Id="CA1419" Action="Warning" />       <!-- Provide a public parameterless constructor for concrete types derived from 'System.Runtime.InteropServices.SafeHandle' -->
     <Rule Id="CA1501" Action="None" />          <!-- Avoid excessive inheritance -->
     <Rule Id="CA1502" Action="None" />          <!-- Avoid excessive complexity -->
     <Rule Id="CA1505" Action="None" />          <!-- Avoid unmaintainable code -->

src/libraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.Keychain.macOS.cs

@@ -401,7 +401,7 @@ internal sealed class SafeTemporaryKeychainHandle : SafeKeychainHandle
         private static readonly Dictionary<IntPtr, SafeTemporaryKeychainHandle> s_lookup =
             new Dictionary<IntPtr, SafeTemporaryKeychainHandle>();
 
-        internal SafeTemporaryKeychainHandle()
+        public SafeTemporaryKeychainHandle()
         {
         }
 

src/libraries/Common/src/Interop/Windows/HttpApi/Interop.HttpApi.cs

@@ -508,7 +508,7 @@ internal sealed class SafeLocalFreeChannelBinding : ChannelBinding
         {
             private int _size;
 
-            private SafeLocalFreeChannelBinding() { }
+            public SafeLocalFreeChannelBinding() { }
 
             public override int Size
             {

src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs

@@ -128,7 +128,7 @@ public static int SetContextAttributes(
 
     internal sealed class SafeFreeContextBuffer_SECURITY : SafeFreeContextBuffer
     {
-        internal SafeFreeContextBuffer_SECURITY() : base() { }
+        public SafeFreeContextBuffer_SECURITY() : base() { }
 
         protected override bool ReleaseHandle()
         {

src/libraries/Common/src/Microsoft/Win32/SafeHandles/Asn1SafeHandles.Unix.cs

@@ -68,15 +68,15 @@ public override bool IsInvalid
 
     internal sealed class SafeSharedAsn1IntegerHandle : SafeInteriorHandle
     {
-        private SafeSharedAsn1IntegerHandle() :
+        public SafeSharedAsn1IntegerHandle() :
             base(IntPtr.Zero, ownsHandle: true)
         {
         }
     }
 
     internal sealed class SafeSharedAsn1OctetStringHandle : SafeInteriorHandle
     {
-        private SafeSharedAsn1OctetStringHandle() :
+        public SafeSharedAsn1OctetStringHandle() :
             base(IntPtr.Zero, ownsHandle: true)
         {
         }

src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs

@@ -18,7 +18,8 @@ public override bool IsInvalid
         }
 
         protected override bool ReleaseHandle() => throw new PlatformNotSupportedException();
-        private SafeGssNameHandle()
+
+        public SafeGssNameHandle()
             : base(IntPtr.Zero, true)
         {
         }
@@ -27,7 +28,7 @@ private SafeGssNameHandle()
     [UnsupportedOSPlatform("tvos")]
     internal sealed class SafeGssCredHandle : SafeHandle
     {
-        private SafeGssCredHandle()
+        public SafeGssCredHandle()
             : base(IntPtr.Zero, true)
         {
         }
@@ -43,7 +44,7 @@ public override bool IsInvalid
     [UnsupportedOSPlatform("tvos")]
     internal sealed class SafeGssContextHandle : SafeHandle
     {
-        private SafeGssContextHandle()
+        public SafeGssContextHandle()
             : base(IntPtr.Zero, true)
         {
         }

src/libraries/Common/src/Microsoft/Win32/SafeHandles/SafeUnicodeStringHandle.cs

@@ -4,6 +4,8 @@
 using System;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace Microsoft.Win32.SafeHandles
 {
     /// <summary>

src/libraries/Common/src/System/Net/Security/SecurityContextTokenHandle.cs

@@ -16,7 +16,7 @@ internal sealed class SecurityContextTokenHandle : CriticalHandleZeroOrMinusOneI
 #endif
         private int _disposed;
 
-        private SecurityContextTokenHandle() : base()
+        public SecurityContextTokenHandle() : base()
         {
         }
 

src/libraries/Common/src/System/Net/Security/Unix/SafeDeleteNegoContext.cs

@@ -7,6 +7,8 @@
 using System.Text;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeDeleteNegoContext : SafeDeleteContext

src/libraries/Common/src/System/Net/Security/Unix/SafeDeleteSslContext.cs

@@ -11,6 +11,8 @@
 using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeDeleteSslContext : SafeDeleteContext